Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] website_event_sale_b2x_alt_price: Migration to version 17.0 #418

Merged

Conversation

pilarvargas-tecnativa
Copy link

Jairo Llopis and others added 16 commits December 10, 2024 17:03
…events

This module extends the functionality of website event sales to support
displaying the alternative price in the website event registration page and to
allow your visitors to know the final price in case they will have some special
fiscal tax behavior.

@Tecnativa TT29393
Currently translated at 100.0% (1 of 1 strings)

Translation: event-15.0/event-15.0-website_event_sale_b2x_alt_price
Translate-URL: https://translation.odoo-community.org/projects/event-15-0/event-15-0-website_event_sale_b2x_alt_price/it/
When the module is installed and the price is not taxed, as it also adds
the flex-column class vertically it tries to occupy the full height of
the container and rises to the top instead of being vertically centred.
Removing the align-self-stretch class avoids this behaviour.

TT44699
Currently translated at 100.0% (1 of 1 strings)

Translation: event-15.0/event-15.0-website_event_sale_b2x_alt_price
Translate-URL: https://translation.odoo-community.org/projects/event-15-0/event-15-0-website_event_sale_b2x_alt_price/es/
@pedrobaeza
Copy link
Member

/ocabot migration website_event_sale_b2x_alt_price

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Dec 11, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 11, 2024
19 tasks
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible for the text to stay on a single line?

image

V15
image

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 17.0-mig-website_event_sale_b2x_alt_price branch from 10aeb09 to 6e21803 Compare December 12, 2024 08:08
@pilarvargas-tecnativa
Copy link
Author

Is it possible for the text to stay on a single line?

The least harmful is to add a small css setting and reduce the text only for events as the problem comes from the html structure of the Odoo template for single-ticket events. In the case of multiple tickets there is no problem but for 1 ticket the structure defines grids that are not quite right.

image

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 17.0-mig-website_event_sale_b2x_alt_price branch from 6e21803 to 51a955e Compare December 12, 2024 14:22
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 17.0-mig-website_event_sale_b2x_alt_price branch from 51a955e to 5566413 Compare December 12, 2024 15:12
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested 👍

Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-418-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 334ea8a. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 935ed35 into OCA:17.0 Dec 13, 2024
7 checks passed
@pedrobaeza pedrobaeza deleted the 17.0-mig-website_event_sale_b2x_alt_price branch December 13, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants