-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] website_event_sale_b2x_alt_price: Migration to version 17.0 #418
[17.0][MIG] website_event_sale_b2x_alt_price: Migration to version 17.0 #418
Conversation
…events This module extends the functionality of website event sales to support displaying the alternative price in the website event registration page and to allow your visitors to know the final price in case they will have some special fiscal tax behavior. @Tecnativa TT29393
Currently translated at 100.0% (1 of 1 strings) Translation: event-15.0/event-15.0-website_event_sale_b2x_alt_price Translate-URL: https://translation.odoo-community.org/projects/event-15-0/event-15-0-website_event_sale_b2x_alt_price/it/
When the module is installed and the price is not taxed, as it also adds the flex-column class vertically it tries to occupy the full height of the container and rises to the top instead of being vertically centred. Removing the align-self-stretch class avoids this behaviour. TT44699
Currently translated at 100.0% (1 of 1 strings) Translation: event-15.0/event-15.0-website_event_sale_b2x_alt_price Translate-URL: https://translation.odoo-community.org/projects/event-15-0/event-15-0-website_event_sale_b2x_alt_price/es/
/ocabot migration website_event_sale_b2x_alt_price |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10aeb09
to
6e21803
Compare
The least harmful is to add a small css setting and reduce the text only for events as the problem comes from the html structure of the Odoo template for single-ticket events. In the case of multiple tickets there is no problem but for 1 ticket the structure defines grids that are not quite right. |
6e21803
to
51a955e
Compare
51a955e
to
5566413
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 334ea8a. Thanks a lot for contributing to OCA. ❤️ |
cc @Tecnativa TT51967
@chienandalu @carlos-lopez-tecnativa please review