Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][REF] sale_product_pack: improve coverage and make it easy to overload #159

Closed
wants to merge 2 commits into from
Closed

[14.0][REF] sale_product_pack: improve coverage and make it easy to overload #159

wants to merge 2 commits into from

Conversation

petrus-v
Copy link
Contributor

@petrus-v petrus-v commented Jan 18, 2024 •
edited
Loading

  • improve coverage
  • refactor unlink order line product pack to make it more robust over use cases
  • refactor to be able to update other fields on sale order line from other modules

@OCA-git-bot
Copy link
Contributor

Hi @ernestotejeda,
some modules you are maintaining are being modified, check this out!

@petrus-v petrus-v marked this pull request as draft January 18, 2024 10:56
@petrus-v
Copy link
Contributor Author

waiting #160 before rebase to fix pre-commit

@petrus-v petrus-v force-pushed the 14.0-foodles-contract-20240116 branch from d544e24 to 5ce594c Compare January 23, 2024 16:52
@petrus-v
[REF] sale_product_pack: improve coverage and refactors
1fe287c 
* improve coverage and add more test while unlink pack order line
* refactor code according those tests
* gives an easy way to add fields that trigger expand components
@petrus-v petrus-v force-pushed the 14.0-foodles-contract-20240116 branch from 5ce594c to 1fe287c Compare January 23, 2024 16:55
@petrus-v petrus-v changed the title WIP [REF] sale_product_pack: make it easy to overwrite [REF] sale_product_pack: make it easy to overwrite Jan 23, 2024
@petrus-v petrus-v marked this pull request as ready for review January 23, 2024 16:56
@petrus-v petrus-v changed the title [REF] sale_product_pack: make it easy to overwrite [14.0][REF] sale_product_pack: make it easy to overwrite Jan 23, 2024
@petrus-v petrus-v changed the title [14.0][REF] sale_product_pack: make it easy to overwrite [14.0][REF] sale_product_pack: improve coverage and make it easy to overload Jan 23, 2024
@petrus-v petrus-v mentioned this pull request Jan 23, 2024
Closed
damdam-s
damdam-s approved these changes Jan 24, 2024
View reviewed changes
sale_product_pack/models/sale_order_line.py Outdated Show resolved Hide resolved
@petrus-v @damdam-s
Update sale_product_pack/models/sale_order_line.py
b6723fd 
Co-authored-by: Damien Crier <Damien.crier@foodles.co>
@rousseldenis rousseldenis added enhancement New feature or request needs review labels Mar 14, 2024
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 14, 2024
@github-actions github-actions bot closed this Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdam-s damdam-s damdam-s approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petrus-v @OCA-git-bot @damdam-s @rousseldenis