[17.0][FIX] sale_product_pack: Respect the order of the lines to be added #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ernestotejeda, |
chienandalu
approved these changes
Oct 29, 2024
|
Please change the maintainer of the module to you. |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 71fa9d2. Thanks a lot for contributing to OCA. ❤️ |
teamcore-admin
pushed a commit
to t-core-one/oca-product-pack
that referenced
this pull request
Nov 7, 2024
* [ADD] product_pack: Add compatibility with website_sale. * [ADD] product_pack: Allow product pack modify * [ADD] product_pack: In sale order do not let to delete/modify a line that belongs to a pack * [ADD] product_pack: Be able to edit pack lines inf allow_modify_pack is set in product. * [ADD] product_pack: Do not compute price in cart for components_price packs [FIX] product_pack: Pack line price fixed (take into account pricelist) (OCA#187) * [FIX] product_pack: Pack line price fixed (take into account pricelist) Proper compute pack line price using price instead of list_price * [FIX] product_pack: Allow Modidy Pack only showed for Components price packs * [FIX] product_pack: When changing pack_price_type clean allow_modify_pack if needed.
ALopez-Adhoc
pushed a commit
to adhoc-dev/product-pack
that referenced
this pull request
Nov 20, 2024
* [ADD] product_pack: Add compatibility with website_sale. * [ADD] product_pack: Allow product pack modify * [ADD] product_pack: In sale order do not let to delete/modify a line that belongs to a pack * [ADD] product_pack: Be able to edit pack lines inf allow_modify_pack is set in product. * [ADD] product_pack: Do not compute price in cart for components_price packs [FIX] product_pack: Pack line price fixed (take into account pricelist) (OCA#187) * [FIX] product_pack: Pack line price fixed (take into account pricelist) Proper compute pack line price using price instead of list_price * [FIX] product_pack: Allow Modidy Pack only showed for Components price packs * [FIX] product_pack: When changing pack_price_type clean allow_modify_pack if needed.
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/oca-product-pack
that referenced
this pull request
Jan 14, 2025
* [ADD] product_pack: Add compatibility with website_sale. * [ADD] product_pack: Allow product pack modify * [ADD] product_pack: In sale order do not let to delete/modify a line that belongs to a pack * [ADD] product_pack: Be able to edit pack lines inf allow_modify_pack is set in product. * [ADD] product_pack: Do not compute price in cart for components_price packs [FIX] product_pack: Pack line price fixed (take into account pricelist) (OCA#187) * [FIX] product_pack: Pack line price fixed (take into account pricelist) Proper compute pack line price using price instead of list_price * [FIX] product_pack: Allow Modidy Pack only showed for Components price packs * [FIX] product_pack: When changing pack_price_type clean allow_modify_pack if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FWP from 16.0: #186
Respect the order of the lines to be added
Before
After
Please @pedrobaeza and @chienandalu can you review it?
@Tecnativa TT51380