[FIX][15.0] base_report_to_printer: Fix access error on product label #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…label from product.product because IDs are used on the wrong model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When printing a product label using the button
Print Labelon the form view forproduct.productthe record ID is used on the model defined on the report. The reports are usually defined onproduct.template[1] which causes that theproduct.productID is used onproduct.templatecauses an access error in best case or the title of different products to be used.active_modelin data is set due to [2] of the wizard.This seems to be the bug for all versions and this might also be the case for the issue #350
[1] https://github.com/OCA/OCB/blob/15.0/addons/product/report/product_reports.xml
[2] https://github.com/OCA/OCB/blob/15.0/addons/product/wizard/product_label_layout.py#L60