Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] report_qweb_parameter: out and raw doesn't work with conditionals #963

Merged
merged 1 commit into from
Jan 15, 2025
Merged

[16.0][FIX] report_qweb_parameter: out and raw doesn't work with conditionals #963

merged 1 commit into from
Jan 15, 2025
+52 −11

Conversation

ValentinVinagre
Copy link
Contributor

Fix + Tests
I-6830

@ValentinVinagre
Copy link
Contributor Author

@HaraldPanten @etobella

@ValentinVinagre ValentinVinagre force-pushed the 16.0-fix-report_qweb_parameter branch from efd4d85 to 033a61e Compare January 15, 2025 11:40
@ValentinVinagre ValentinVinagre force-pushed the 16.0-fix-report_qweb_parameter branch from 033a61e to f47459b Compare January 15, 2025 11:43
HaraldPanten
HaraldPanten approved these changes Jan 15, 2025
View reviewed changes
Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ValentinVinagre ValentinVinagre changed the title [FIX] report_qweb_parameter: out and raw doesn't work with conditionals [16.0][FIX] report_qweb_parameter: out and raw doesn't work with conditionals Jan 15, 2025
etobella
etobella approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, on the original function it was defined, but when creating the t-out directive it was forgotten.

Thanks for finding it.

@etobella
Copy link
Member

/ocabot merge patch

Fast tracking, as it might affect other modules like Spanish Facturae

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-963-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9de6ebe. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit a05f7ae into OCA:16.0 Jan 15, 2025
7 checks passed
@ValentinVinagre ValentinVinagre deleted the 16.0-fix-report_qweb_parameter branch January 15, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaraldPanten HaraldPanten HaraldPanten approved these changes

@etobella etobella etobella approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ValentinVinagre @etobella @OCA-git-bot @HaraldPanten