Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] fastapi: update schema to json_schema_extra #388

Closed

Conversation

sbouillon
Copy link

PydanticDeprecatedSince20: Using extra keyword arguments on Field is deprecated and will be removed. Use json_schema_extra instead. (Extra keys: 'desciption'). Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.4/migration/

PydanticDeprecatedSince20: Using extra keyword arguments on `Field` is deprecated and will be removed. Use `json_schema_extra` instead. (Extra keys: 'desciption'). Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.4/migration/
@OCA-git-bot
Copy link
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@sbouillon sbouillon changed the title Update schemas.py [16.0] fastapi: update schema to json_schema_extra Oct 31, 2023
@lmignon
Copy link
Contributor

lmignon commented Nov 1, 2023

Hi @sbouillon

Thank you for the proposal. Nevertheless this warning comes from a typo fixed here Your fix is not the correct one. I propose to close your PR. Feels free to reopen it if you think I'm wrong.

Regards

@lmignon lmignon closed this Nov 1, 2023
@sbouillon
Copy link
Author

You're right. I wasn't looking closely enough :)

@sbouillon sbouillon deleted the fastapi-pydantic-deprecation-2.0 branch November 10, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants