[17.0][FIX] fastapi: partner env for tests #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`partner` record leaks default env and even if you specify `default_fastapi_running_user` to be custom user, when running tests, running env will still have default (superuser), which makes testing outcomes very different than you might expect. Setting `partner` to use env with specified user, makes sure it won't leak from there.
|
Hi @lmignon, |
lmignon
changed the title
lmignon
approved these changes
Dec 11, 2024
|
@lmignon when you plan to merge it? |
I would like to collect more feedback from others users. |
|
Seems fair and would explain some false negative I got 👍 |
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 9d24e36. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partnerrecord leaks default env and even if you specifydefault_fastapi_running_userto be custom user, when running tests, running env will still have default (superuser), which makes testing outcomes very different than you might expect.Setting
partnerto use env with specified user, makes sure it won't leak from there.