[16.0][FIX] mail_tracking: validated mailbox when computing isInFailedDiscuss #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
payen000
force-pushed
the
16.0-mail_tracking-isinfaileddiscuss-fix-payen
branch
from
e0512dd to
63f88e6
Compare
payen000
force-pushed
the
16.0-mail_tracking-isinfaileddiscuss-fix-payen
branch
from
63f88e6 to
a554863
Compare
|
Hello @remi-filament, Thank you for bringing this issue to my attention, could you test the fix in runboat, please? |
remi-filament
approved these changes
Oct 17, 2023
pedrobaeza
changed the title
chienandalu
approved these changes
Oct 17, 2023
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 82f3e60. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #1235
The error is triggered because there is no mailbox assigned to threads when clicking on a channel, and is also triggered when checking direct messages. This fix addresses both cases.