Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] stock_picking_partner_note #1739

Open
wants to merge 17 commits into
base: 17.0
Choose a base branch
from

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Oct 8, 2024

No description provided.

santostelmo and others added 15 commits October 8, 2024 18:12
Currently translated at 100.0% (22 of 22 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_partner_note
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_partner_note/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_partner_note
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_partner_note/
Currently translated at 100.0% (28 of 28 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_partner_note
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_partner_note/it/
Currently translated at 100.0% (28 of 28 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_partner_note
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_partner_note/it/
@astirpe astirpe marked this pull request as ready for review October 8, 2024 16:25
Copy link

@scigghia scigghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just some cosmetic suggestions to consider.

stock_picking_partner_note/models/res_config_settings.py Outdated Show resolved Hide resolved
stock_picking_partner_note/models/stock_picking_note.py Outdated Show resolved Hide resolved
stock_picking_partner_note/readme/CONFIGURE.md Outdated Show resolved Hide resolved
stock_picking_partner_note/readme/DESCRIPTION.md Outdated Show resolved Hide resolved
and n.note_type_id in ptnts
)
picking_notes = [
note.name.strip()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to apply odoo.tools.html_escape to the names, given that we're filling a html field with text content?

Copy link
Member Author

@astirpe astirpe Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StefanRijnhart sorry for the delay, I missed this code review. Thank you BTW! I applied html_escape, would you check?

@rousseldenis
Copy link
Contributor

/ocabot migration stock_picking_partner_note

Update stock_picking_partner_note/models/res_config_settings.py
Update stock_picking_partner_note/models/stock_picking_note.py
Update stock_picking_partner_note/readme/CONFIGURE.md
Update stock_picking_partner_note/readme/DESCRIPTION.md

Co-authored-by: Stefan Rijnhart (Opener) <stefan@opener.amsterdam>
@astirpe astirpe force-pushed the 17_mig_stock_picking_partner_note branch from bf60c85 to 71b0a6e Compare January 15, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants