-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] stock_picking_partner_note #1739
base: 17.0
Are you sure you want to change the base?
Conversation
Currently translated at 100.0% (22 of 22 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_partner_note Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_partner_note/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_partner_note Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_partner_note/
Currently translated at 100.0% (28 of 28 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_partner_note Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_partner_note/it/
Currently translated at 100.0% (28 of 28 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_partner_note Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_partner_note/it/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just some cosmetic suggestions to consider.
and n.note_type_id in ptnts | ||
) | ||
picking_notes = [ | ||
note.name.strip() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to apply odoo.tools.html_escape to the names, given that we're filling a html field with text content?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StefanRijnhart sorry for the delay, I missed this code review. Thank you BTW! I applied html_escape, would you check?
/ocabot migration stock_picking_partner_note |
Update stock_picking_partner_note/models/res_config_settings.py Update stock_picking_partner_note/models/stock_picking_note.py Update stock_picking_partner_note/readme/CONFIGURE.md Update stock_picking_partner_note/readme/DESCRIPTION.md Co-authored-by: Stefan Rijnhart (Opener) <stefan@opener.amsterdam>
bf60c85
to
71b0a6e
Compare
No description provided.