Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(other): bump @faker-js/faker from 5.1.0 to 8.4.1 in /webapp and adapt repo-wide code to deprecation warnings #6999

Merged
merged 8 commits into from
May 1, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 10, 2024

Bumps @faker-js/faker from 5.1.0 to 8.4.1.

Release notes

Sourced from @​faker-js/faker's releases.

v8.4.1

What's Changed

Full Changelog: faker-js/faker@v8.4.0...v8.4.1

v8.4.0

What's Changed

... (truncated)

Changelog

Sourced from @​faker-js/faker's changelog.

8.4.1 (2024-02-06)

  • JSDocs improvements

8.4.0 (2024-01-24)

Features

  • helpers: add support for complex intermediate types (#2550) (24482a3)
  • number: add parameter fractionDigits in float (#1855) (41d8778)
  • person: add job titles for fr (#2531) (ba28ab6)

Bug Fixes

  • finance: correct VG IBAN format (#2552) (b8049d1)
  • internet: username method to return value that always includes… (#2506) (0ee1c67)
  • locale: incomplete airline names in zh_CN (#2558) (5525b55)
  • number: improve float generation for precisions of form 10^-n (#2581) (39c715d)

8.3.1 (2023-11-14)

Bug Fixes

  • remove [@internal](https://github.com/internal) from module parent classes (#2548) (77f54ad)

8.3.0 (2023-11-14)

Features

Bug Fixes

  • date: ensures correct range for birthdate (#2535) (7ce8c28)
  • finance: maskedNumber has incorrect defaults (#2494) (e0ba50b)
  • locale: improve Swedish phone numbers format (#2520) (e4865df)

Changed Locales

  • locale: remove fr_CH data which is identical to fr (#2526) (fafcba4)

New Locales

... (truncated)

Commits
Maintainer changes

This version was pushed to npm by shinigami92, a new releaser for @​faker-js/faker since your current version.


Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Issues

@mahula
Copy link
Contributor

mahula commented Mar 2, 2024

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/webapp/faker-js/faker-8.4.1 branch from 8c1903b to d03b20c Compare March 2, 2024 15:11
@mahula mahula self-assigned this Apr 29, 2024
@mahula
Copy link
Contributor

mahula commented Apr 29, 2024

@dependabot rebase

Bumps [@faker-js/faker](https://github.com/faker-js/faker) from 5.1.0 to 8.4.1.
- [Release notes](https://github.com/faker-js/faker/releases)
- [Changelog](https://github.com/faker-js/faker/blob/next/CHANGELOG.md)
- [Commits](faker-js/faker@v5.1.0...v8.4.1)

---
updated-dependencies:
- dependency-name: "@faker-js/faker"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/webapp/faker-js/faker-8.4.1 branch from d03b20c to 8c35728 Compare April 29, 2024 05:25
@mahula mahula changed the title Bump @faker-js/faker from 5.1.0 to 8.4.1 in /webapp build(other): bump @faker-js/faker from 5.1.0 to 8.4.1 in /webapp Apr 29, 2024
@Tirokk
Copy link
Member

Tirokk commented Apr 29, 2024

In general it seems to be working!
@mahula

On yarn db:reset && yarn db:seed have the warning [@faker-js/faker]: faker.internet.avatar() is deprecated since v8.4 and will be removed in v9.0. Please use faker.image.avatarLegacy() or faker.image.avatar() instead.. @mahula

If we run the webapp locally we get the depricated warning:

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(-$size, 3) or calc(-1 * $size / 3)

More info and automated migrator: https://sass-lang.com/d/slash-div

     ╷
1180 │       margin-right: -$size / 3;
     │                     ^^^^^^^^^^
     ╵
    components/Badges.vue 1180:21  root stylesheet

@mahula
Copy link
Contributor

mahula commented Apr 29, 2024

On yarn db:reset && yarn db:seed have the warning [@faker-js/faker]: faker.internet.avatar() is deprecated since v8.4 and will be removed in v9.0. Please use faker.image.avatarLegacy() or faker.image.avatar() instead..

This PR is about the webapp's faker package, but the deprecation warning relates to the backend's faker package.
Avatar fakin' adaptationhas been addressed now in 01c8c2a

If we run the webapp locally we get the depricated warning:

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(-$size, 3) or calc(-1 * $size / 3)

More info and automated migrator: https://sass-lang.com/d/slash-div

     ╷
1180 │       margin-right: -$size / 3;
     │                     ^^^^^^^^^^
     ╵
    components/Badges.vue 1180:21  root stylesheet

This deprecation warning is out of this PR's scopus and referring to SASS.

@mahula mahula closed this Apr 29, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 29, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/webapp/faker-js/faker-8.4.1 branch April 29, 2024 12:29
@mahula mahula restored the dependabot/npm_and_yarn/webapp/faker-js/faker-8.4.1 branch April 29, 2024 12:30
@mahula mahula reopened this Apr 29, 2024
@mahula mahula marked this pull request as draft April 29, 2024 13:49
@mahula mahula changed the title build(other): bump @faker-js/faker from 5.1.0 to 8.4.1 in /webapp build(other): bump @faker-js/faker from 5.1.0 to 8.4.1 in /webapp and adapt repo-wide code to deprecation warnings Apr 29, 2024
@mahula mahula changed the title build(other): bump @faker-js/faker from 5.1.0 to 8.4.1 in /webapp and adapt repo-wide code to deprecation warnings refactor(other): bump @faker-js/faker from 5.1.0 to 8.4.1 in /webapp and adapt repo-wide code to deprecation warnings Apr 29, 2024
@mahula mahula marked this pull request as ready for review April 29, 2024 16:04
@Tirokk
Copy link
Member

Tirokk commented Apr 30, 2024

This deprecation warning is out of this PR's scopus and referring to SASS.

I created the issue #7340 @mahula

Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work nicely.

Thanks for carring @mahula ! 🥰

PS: Storybook is not running anymore, but this seems not related to this PR. I created issue #7341

@mahula mahula merged commit 2576bab into master May 1, 2024
42 checks passed
@mahula mahula deleted the dependabot/npm_and_yarn/webapp/faker-js/faker-8.4.1 branch May 1, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants