fix: Finishing the activity on main thread when a notification is opened #2353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Crash occurring when a notification was opened.
Details
Motivation
The below crash was happening when a notification was received and clicked to open.
Scope
The activity was finished by the background thread earlier. So even before all the internal methods of onCreate were actually complete (on main thread), the finish method would be called by the background thread causing a crash.
OPTIONAL - Other
Testing
Unit testing
Added couple of tests
Manual testing
Tested opening a notification while the app was foregrounded, app build with Android Studio 2025.1.2 with a fresh install of the OneSignal example app on a emulator running Api 36.0
Affected code checklist
Checklist
Overview
Testing
Final pass
Kapture.2025-08-22.at.12.04.09.mp4
This change is