Refactor: config class rewrite #202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Typed config - Separate sections in object - Easy and clean interface - Reusable
Root-Core
force-pushed
the
refactor_config
branch
from
587ba0c to
c6c82b7
Compare
Root-Core
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked and adopted from #152
This is probably not a necessary change, but still a big improvement, and allows static type checking of the config file. It also provides a nice API for config that guides the user quite well. It is easily extensible, and I hope we make more use of config in the future. ENV variables are nice, but a bit of a guessing game. A good config file could solve a lot of problems.