Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SubDyn: direction cosine matrix has no checks #2634

Closed
andrew-platt opened this issue Feb 12, 2025 · 1 comment
Closed

SubDyn: direction cosine matrix has no checks #2634

andrew-platt opened this issue Feb 12, 2025 · 1 comment
Assignees
@RBergua @luwang00
Labels
Module: SubDyn Type: Bug
Milestone
v5.0.0

Comments

@andrew-platt
Copy link
Collaborator

Bug description
The direction cosine matrix input to SubDyn currently has no checks to ensure it is valid.

Proposed solutions

  1. Remove the cosine matrix
  2. add checks on the input and set to closest (rescale, convert to euler angle, then back)
@andrew-platt andrew-platt added this to the v5.0.0 milestone Feb 12, 2025
@luwang00 luwang00 mentioned this issue Feb 21, 2025
Open
@andrew-platt
Copy link
Collaborator Author

#2646 closes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RBergua RBergua

@luwang00 luwang00

Labels
Module: SubDyn Type: Bug
Projects
None yet
Milestone
v5.0.0
Development

No branches or pull requests
3 participants
@andrew-platt @RBergua @luwang00