-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of rectangular members in HD and SD #2646
Open
luwang00
wants to merge
42
commits into
OpenFAST:dev
Choose a base branch
from
luwang00:f/RectangularMembers
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly finished member and joint initialization
…ngular members. Also introduced spin about member axis.
…oading for rectangular members
…hydrostatic loads if one of the edge length is zero
…al and rectangular members, added missing input checks, and made various other small fixes
Also patched up the arbitrary-section beam implementation.
…lar (for outputs), rectangular, and arbitrary sections
…arbitrary sections
…rectangular beam sections * Added alternative torsion constant and shear coefficient estimates for solid rectangular sections in addition to thin-walled sections. * Use a more accurate formula for the shear coefficient of thin-walled rectangular sections. * Added a warning message if the section is neither solid nor thin-walled. * Other small bug fixes.
…an existing entry in the MEMBER COSINE MATRICES table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
This PR adds the implementation of rectangular members in HydroDyn and SubDyn. It also includes various other bug fixes and improvements including the following:
HydroDyn
SubDyn
COSMID
of a spring member references a nonexistent entry in the direction cosine matrix table. Previously, it defaults back to the identity matrix by a series of coincidence without reporting an error.OpenFAST_IO
TO-DOs
The HydroDyn strip-theory member visualization should be updated to support rectangular members. @andrew-platt and @deslaughter will help with this.
Related issue, if one exists
Issue #2634
Impacted areas of the software
HydroDyn, SubDyn, OpenFAST_IO
Test results, if applicable