Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Update create_FAST_SFunc.m for Windows, update docs on Simulink MEX building #2621

Merged
merged 5 commits into from
Jan 30, 2025

Conversation

andrew-platt
Copy link
Collaborator

@andrew-platt andrew-platt commented Jan 30, 2025

Ready to merge

Feature or improvement description
The create_FAST_SFunc.m script was missing the path to ExtLoadsDX_Types.h. Also cleaned up a few things:

  • Add documentation building the Simulink MEX function
  • Update documentation on CMake options
  • Remove Mac/Linux/CMake support from create_FAST_SFunc.m and add directions to use CMake instead

Related issue, if one exists
Fixes #2606

Impacted areas of the software
MATLAB SFunc building on Windows systems was not working

Test results, if applicable
No test results are affected.

@andrew-platt
Copy link
Collaborator Author

create_FAST_SFunc.m doesn't appear to work with the CMake build system anymore on *nix systems. Should we modify this script to tell the user how to build the FAST_SFunc with CMake, and where to find it afterwards?

Copy link
Collaborator

@deslaughter deslaughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments at the top of the file say that if you're using CMake to build OpenFAST you can specify -DBUILD_OPENFAST_SIMULINK_API=ON to create the mex file. However, it doesn't say exactly where the file will be created. Should be build/glue-codes/simulink/FAST_SFunc.mexXXXX.

@andrew-platt andrew-platt changed the title Bugfix: missing include path in create_FAST_SFunc.m Bugfix: Update create_FAST_SFunc.m for Windows, update docs on Simulink MEX building Jan 30, 2025
andrew-platt added a commit that referenced this pull request Jan 30, 2025
@andrew-platt andrew-platt merged commit c04bf08 into OpenFAST:rc-4.0.1 Jan 30, 2025
66 checks passed
@andrew-platt andrew-platt deleted the b/SFunc_build branch February 5, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants