Fix MacOS compilation with xcode16.3/clang17/gcc14 #5207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that this fixes #5202 for me, although we eventually need to figure out how to build without |
|
The xcode release notes for 15.x relate the errors to the presence of weak symbols, and acknowledge that C++ projects make extensive use of them - so hopefully the deprecated ld_classic that Apple themselves suggest to use as a workaround will not actually be removed before this problem is solved. |
|
I'll try and test this with spack...once I figure out how to test this with spack... Forks are fun! (Worse comes to worse, I use your change in a patch...which is probably needed anyway.) |
This was referenced Apr 8, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5202