Web-Config and Various Fixes for RC2 #1333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lusion for web-config, actual JSON_OBJECT_SIZE() calls for our web config requests - WebApi.js and Http.ts fixes for Promise.all to prevent all of the EMPTY connections - DisplayConfig.jsx fix for setDisplayOptions in preview mode STILL having crashes for preview mode, but this fixes a good number of things
|
Replaced this with PR#1335 and PR#1336 Still doesn't fix the crash, but doesn't make sense to merge all of this as a single PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of improvements for RC2, including proper JSON_ARRAY_SIZE() inclusion for web-config, actual JSON_OBJECT_SIZE() calls for our web config requests
STILL having crashes for preview mode, but this fixes a good number of things