Web Config Saves Fix + Removing Legacy Code #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed ConfigManager as this idiom never took off and we have better ones in place Modified NetDriver to run rndis making it the controller of web Moved Storage -> config Mode to Driver -> config Mode Fixed no-save issue with web config calls
Web Config Memory + Force Save -> Event Save Fixes (OpenStickCommunity#1336)
…l/GP2040-CE into 20250405_webconfig_saves
arntsonl
commented
Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved config mode check to the DriverManager
Removed ConfigManager as this idiom never took off and we have better ones in place
Modified NetDriver to run rndis making it the controller of web
Moved Storage -> config Mode to Driver -> config Mode
Fixed no-save issue with web config calls