Add GovernorSuperQuorum extension #1427
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ericnordelo , here is the pr for #1385 , please check and let me know if anything needs to be changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1385
This PR introduces the GovernorSuperQuorum extension to the governance module, allowing proposals that achieve a significant majority of FOR votes (the "super quorum") and meet success conditions to pass before the official voting period ends.
This functionality mirrors the Solidity GovernorSuperQuorum extension and addresses issue #1385.
The implementation includes the GovernorSuperQuorumComponent, integration into the extensions module, and the necessary test file structure (test_governor_superquorum.cairo). It features a runtime check to ensure the configured super quorum is not less than the regular quorum, preventing potential vulnerabilities.
The primary goal is to allow faster resolution for proposals that have clear overwhelming support, reducing the waiting time imposed by the standard voting period. Integration requires the host contract to implement the GovernorSuperQuorumInternal trait to provide vote counts and the specific super quorum threshold.
PR Checklist