Skip to content

Macros: Prevent duplicates #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

immrsd
Copy link
Collaborator

@immrsd immrsd commented Aug 20, 2025

Although duplicated components anyway result in compilation error, I think it can be helpful to add the check and corresponding error message

@immrsd immrsd requested a review from ericnordelo August 20, 2025 11:18
@immrsd immrsd self-assigned this Aug 20, 2025
@ericnordelo
Copy link
Member

This should give a compilation error from the Component being imported twice. I think we should avoid front-running compilation errors, to maintain the macro as simple as possible.

Copy link

codecov bot commented Aug 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.35%. Comparing base (f301f03) to head (5fd8a8d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1508   +/-   ##
=======================================
  Coverage   92.35%   92.35%           
=======================================
  Files          82       82           
  Lines        2264     2264           
=======================================
  Hits         2091     2091           
  Misses        173      173           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f301f03...5fd8a8d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants