Skip to content

Re-introduces chain id to SS and commitment store #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

LeoPatOZ
Copy link
Collaborator

This allows the SS to be deployed to multiple chains whilst ensuring signals can be verified against their source chain (this prevents eth deposits to be redeemed on multiple chains for example)

@LeoPatOZ LeoPatOZ changed the base branch from main to signal-service April 17, 2025 15:20
Copy link

Changes to gas cost

Generated at commit: 945984cc5a965c4d0213d25cfb207457fdb5ca3e, compared to commit: a9b795fecea7b1132de8b9f3b58c14b7e3743dd3

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
CheckpointTracker proveTransition +665 ❌ +0.64%
ProverManager prove +668 ❌ +0.52%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
CheckpointTracker 984,197 (+4,760) proveTransition 104,049 (+665) +0.64% 104,049 (+665) +0.64% 104,049 (+665) +0.64% 104,049 (+665) +0.64% 1 (0)
ProverManager 2,854,862 (0) prove 105,854 (+668) +0.64% 127,912 (+668) +0.52% 129,789 (+668) +0.52% 142,470 (+668) +0.47% 6 (0)
SignalService 4,286,056 (+94,187) setAuthorizedCommitter 47,624 (+22) +0.05% 47,624 (+22) +0.05% 47,624 (+22) +0.05% 47,624 (+22) +0.05% 22 (0)

@LeoPatOZ LeoPatOZ closed this Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant