Skip to content

Conversation

kat-1218
Copy link
Contributor

Pull request to review progress on the following documentation pages: grids.py, hierarchy.py, indexing_gpd.py

@steve-kingston steve-kingston added the documentation Improvements or additions to documentation label Aug 21, 2025
Copy link
Contributor

@tompeterken-os2 tompeterken-os2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it :) I think for me it's just the edits to the Errors, which are causing pytest to fail. The ruff failure is only from the .ipnb files, maybe we ought to edit the GitHub Action to ignore notebooks...

@steve-kingston
Copy link
Collaborator

Thanks for the edits @kat-1218! I've added a screenshot to show how the reset_index kwarg of gdf_to_bng_intersection_explode is currently rendering. Would you be able to take a look to see if there's a simple fix? Aside from that looks brilliant and happy for it to be merged

@steve-kingston
Copy link
Collaborator

Happy for the Ruff checks to be ignored as branch docs/sphinx-integration-steve has ruff-ified the Jupyter notebooks

@kat-1218 kat-1218 merged commit a3a8bd1 into docs/sphinx-integration Aug 28, 2025
2 checks passed
@steve-kingston
Copy link
Collaborator

steve-kingston commented Aug 28, 2025 via email

@steve-kingston steve-kingston deleted the docs/sphinx-integration-kate branch September 9, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants