PHP 8.4 compatibility #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity, bump PHP min version to 7.1 to enable nullable parameters, use imports when they are already imported
|
Ive made the unit tests PHP 8.4 compatible too. The problem is, that now the tests only work on 8.1+. The lib itself should work below that but Laminas-Test and PHPUnit have a minimum php version of 8.1. What do you want me to do? I could do more updating to bring the whole lib to 8.1+... |
|
@OxCom Any news? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nullable parameters must be marked as nullabe in PHP 8.4+
e. g.
public function __construct(ContainerInterface $serviceManager, TwigRenderer $renderer = null)The
$rendereris NOT marked as nullable, but has a default value ofnull. So PHP <= 8.3 marks it as nullable implicitely. In PHP 8.4+ you have to mark this parameter as nullable explicitely.I had to bump the PHP min version to 7.1 (from 7.0) because without it parameters cant be marked nullable (with
?).