Skip to content

Conversation

Tobianas
Copy link
Contributor

@Tobianas Tobianas commented Sep 8, 2025

There is no need to set the version since we are getting it already from lighty core.

JIRA: LIGHTY-368

There is no need to set the version since we are getting
it already from lighty core.

JIRA: LIGHTY-368
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Tobianas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request centralizes JUnit dependency management within the lighty project. By removing explicit JUnit declarations from the examples-bom, the project leverages the versions already defined in lighty core. This reduces redundancy and ensures consistent JUnit versions across modules that depend on lighty core.

Highlights

  • Streamlining Dependency Management: Removed explicit JUnit Jupiter API and Engine dependencies from examples-bom/pom.xml as they are now inherited from lighty core, simplifying dependency management.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the explicit dependency management for junit-jupiter-api and junit-jupiter-engine from examples-bom/pom.xml. As stated in the description, the versions are now inherited from lighty-core. This is a good practice that centralizes dependency management, reduces redundancy, and helps prevent version conflicts. The change is a positive step towards better project maintainability.

@ihrasko ihrasko merged commit d26f1ce into PANTHEONtech:main Sep 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants