Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fancy Posts #39

Merged
merged 53 commits into from
Jan 9, 2025
Merged

Fancy Posts #39

merged 53 commits into from
Jan 9, 2025

Conversation

lishaduck
Copy link
Member

@lishaduck lishaduck commented Oct 17, 2024

Description

This PR rewrites, rebrands, and repolishes the entirety of the application.

CC: @MattsAttack


Type of Change

  • ✨ New feature

Checklist

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Fill out this template.
  • Log your hours.
  • Check that commits follow the Angular commit convention, more or less.
  • Ideally, include relevant tests that fail without this PR but pass with it (if applicable).

Tested on

  • CI
  • macOS 14
  • Windows 11

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 30.16393% with 213 lines in your changes missing coverage. Please review.

Project coverage is 37.17%. Comparing base (e8a490d) to head (2741494).

Files with missing lines Patch % Lines
...c/features/auth/presentation/auth/log_in_page.dart 0.00% 56 Missing ⚠️
.../lib/src/features/home/presentation/home/post.dart 53.84% 30 Missing ⚠️
...ttings/presentation/preferences/settings_page.dart 21.87% 25 Missing ⚠️
packages/app/lib/src/app/wrapper_page.dart 0.00% 24 Missing ⚠️
packages/app/lib/src/utils/hooks.dart 0.00% 18 Missing ⚠️
...ib/src/features/home/application/feed_service.dart 15.38% 11 Missing ⚠️
packages/app/lib/src/utils/format.dart 37.50% 10 Missing ⚠️
...pp/lib/src/features/home/data/post_repository.dart 0.00% 9 Missing ⚠️
...eatures/home/presentation/home/post_view_page.dart 0.00% 9 Missing ⚠️
.../src/features/map/presentation/items/map_page.dart 14.28% 6 Missing ⚠️
... and 4 more
Files with missing lines Coverage Δ
packages/app/lib/env/env.dart 60.00% <ø> (ø)
packages/app/lib/src/app/app.dart 4.54% <ø> (ø)
...pp/lib/src/features/auth/data/auth_repository.dart 35.29% <ø> (ø)
.../src/features/home/application/avatar_service.dart 100.00% <100.00%> (ø)
...rc/features/home/application/location_service.dart 100.00% <ø> (ø)
.../lib/src/features/home/data/avatar_repository.dart 100.00% <100.00%> (ø)
...ib/src/features/home/data/location_repository.dart 30.76% <ø> (ø)
.../app/lib/src/features/home/domain/post_entity.dart 0.00% <ø> (ø)
.../lib/src/features/home/presentation/home/feed.dart 100.00% <100.00%> (ø)
...ures/home/presentation/home/feed_routing_page.dart 100.00% <100.00%> (ø)
... and 19 more

... and 1 file with indirect coverage changes

@lishaduck
Copy link
Member Author

@MattsAttack, you pushed a rebase instead of force pushing, so I had to clean it up.
Run git reset origin/fancy-posts.

@MattsAttack
Copy link
Contributor

My bad

@lishaduck
Copy link
Member Author

My bad

Oh, and I did it wrong myself. Give me a few minutes.

@lishaduck
Copy link
Member Author

Ok, you can run git reset --hard origin/fancy-posts now. Keep in mind that it'll wipe everything, so make sure there's nothing unstaged. If there is, memorize it 😉

@MattsAttack
Copy link
Contributor

@lishaduck I believe there's an issue with the app not requesting the users location and then not loading in the local feed. The pop up to request location only pops up sometimes on web and if doesn't theres no way to load in the local feed

@lishaduck
Copy link
Member Author

Might be fixed with #44?

@MattsAttack
Copy link
Contributor

@lishaduck how should I go about getting a username from a user id?

@lishaduck
Copy link
Member Author

@lishaduck how should I go about getting a username from a user id?

For security reasons you, erm, can't. I spent a lot of time looking into it, and it looks like you'd need to a) write a server function, or b) store a user-id => preferred name mapping in a new db collection, which would be annoying.
I pitched it as being anonymous for that reason in the script.

@MattsAttack
Copy link
Contributor

MattsAttack commented Oct 20, 2024

For security reasons you, erm, can't.

What if I just added an attribute to posts that stores the person who created its user name? That should be pretty simple.

@lishaduck
Copy link
Member Author

For security reasons you, erm, can't.

What if I just added an attribute to posts that stores the person who created its user name? That should be pretty simple.

Hm. That'd be fine assuming that we don't allow changing your display name.

@MattsAttack
Copy link
Contributor

MattsAttack commented Oct 20, 2024

Hm. That'd be fine assuming that we don't allow changing your display name.

That's true. But if they were to change it we could update the value of the posts the users made in the data base with their new user name. It's not the best but its probably better than sending an api call every time you load a post

@lishaduck
Copy link
Member Author

That's true. But if they were to change it we could update the value of the posts the users made in the data base with their new user name. It's not the best but its probably better than sending an api call every time you load a post

It would take a while and we could cache it, but yeah, I think it'd be fine. Just write it :)

@MattsAttack
Copy link
Contributor

It would take a while and we could cache it, but yeah, I think it'd be fine. Just write it :)

Ai ai captain

@lishaduck
Copy link
Member Author

@MattsAttack, I know it's too late, but I pushed my changed. you might like the last commit

@lishaduck lishaduck linked an issue Oct 23, 2024 that may be closed by this pull request
1 task
@MattsAttack
Copy link
Contributor

Oh nice! Did you fix the local world tab background?

@lishaduck
Copy link
Member Author

lishaduck commented Oct 23, 2024

Oh nice! Did you fix the local world tab background?

Yup! It was easy-peasy once I'd figured out the issue.

@MattsAttack
Copy link
Contributor

awesome sauce

@lishaduck lishaduck self-assigned this Oct 23, 2024
@MattsAttack MattsAttack added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 07149dc Jan 9, 2025
9 checks passed
@MattsAttack MattsAttack deleted the fancy-posts branch January 9, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI design
2 participants