-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fancy Posts #39
Fancy Posts #39
Conversation
fd55b33
to
7fb27ba
Compare
@MattsAttack, you pushed a rebase instead of force pushing, so I had to clean it up. |
My bad |
Oh, and I did it wrong myself. Give me a few minutes. |
7fb27ba
to
4c36abe
Compare
Ok, you can run |
@lishaduck I believe there's an issue with the app not requesting the users location and then not loading in the local feed. The pop up to request location only pops up sometimes on web and if doesn't theres no way to load in the local feed |
Might be fixed with #44? |
packages/app/lib/src/features/home/presentation/home/feed_routing_page.dart
Show resolved
Hide resolved
@lishaduck how should I go about getting a username from a user id? |
For security reasons you, erm, can't. I spent a lot of time looking into it, and it looks like you'd need to a) write a server function, or b) store a user-id => preferred name mapping in a new db collection, which would be annoying. |
What if I just added an attribute to posts that stores the person who created its user name? That should be pretty simple. |
Hm. That'd be fine assuming that we don't allow changing your display name. |
That's true. But if they were to change it we could update the value of the posts the users made in the data base with their new user name. It's not the best but its probably better than sending an api call every time you load a post |
It would take a while and we could cache it, but yeah, I think it'd be fine. Just write it :) |
Ai ai captain |
51549c3
to
dd6681d
Compare
@MattsAttack, I know it's too late, but I pushed my changed. you might like the last commit |
Oh nice! Did you fix the local world tab background? |
Yup! It was easy-peasy once I'd figured out the issue. |
awesome sauce |
This reverts commit de4d465.
- Write lots of docs. - Update lots of comments. - Delete dead code. - Fix todos.
ValueNotifier works by using a custom setter, so mutating the list wasn't doing anything. This patch sets the `value` property to a clone of the list, fixing it.
2741494
to
bda8374
Compare
Description
This PR rewrites, rebrands, and repolishes the entirety of the application.
CC: @MattsAttack
Type of Change
Checklist
Tested on