Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feeds UI #6

Merged
merged 18 commits into from
Sep 20, 2024
Merged

Feeds UI #6

merged 18 commits into from
Sep 20, 2024

Conversation

MattsAttack
Copy link
Contributor

@MattsAttack MattsAttack commented Sep 16, 2024

Description

This PR adds in feeds.


Type of Change

  • ✨ New feature

Checklist

Checklist

Preview Give feedback

Tested on

  • macOS 14

* quick commit. basic feed implementation. Need testing and can't get routing to work
* changed feed.dart to feed_page.dart and made it initial to test
* added photo param to post class
* fixed post constructer and began local and world feed implementation
* added str feed parameters to feed and continued local/world feed implementation
* tab navigation for world and local feed. Need to fix "HomeRoute does not have children error." Had it happen on earlier commits but thought it was a route build issue
* Fixed routing errors. Local and world feed work now :). Need to find widget to move them to top(probably app bar but we need to change the implementation in routing)
* fixed tab names
* push for elisha dukes. still need to make it infinite
* refactor: all of it
* feat: move navbar to top
* chore: remove me

Co-authored-by: Eli <88557639+lishaduck@users.noreply.github.com>
@MattsAttack MattsAttack requested a review from a team as a code owner September 16, 2024 18:24
@lishaduck lishaduck marked this pull request as draft September 17, 2024 18:16
@MattsAttack MattsAttack marked this pull request as ready for review September 20, 2024 17:46
Copy link
Member

@lishaduck lishaduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like good code, I guess.

@lishaduck lishaduck disabled auto-merge September 20, 2024 18:02
@lishaduck lishaduck added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 1e8b9ef Sep 20, 2024
9 of 10 checks passed
@lishaduck lishaduck deleted the ui-testing branch September 20, 2024 18:08
@lishaduck lishaduck mentioned this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants