-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feeds UI #6
Merged
Merged
Feeds UI #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* quick commit. basic feed implementation. Need testing and can't get routing to work * changed feed.dart to feed_page.dart and made it initial to test * added photo param to post class * fixed post constructer and began local and world feed implementation * added str feed parameters to feed and continued local/world feed implementation * tab navigation for world and local feed. Need to fix "HomeRoute does not have children error." Had it happen on earlier commits but thought it was a route build issue * Fixed routing errors. Local and world feed work now :). Need to find widget to move them to top(probably app bar but we need to change the implementation in routing) * fixed tab names * push for elisha dukes. still need to make it infinite * refactor: all of it * feat: move navbar to top * chore: remove me Co-authored-by: Eli <88557639+lishaduck@users.noreply.github.com>
There's other async code now, so we don't need this example.
Just to be consistent.
lishaduck
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like good code, I guess.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds in feeds.
Type of Change
Checklist
Checklist
Tested on