-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home page of Docs website #11
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests and there are no merge conflicts. The process helps maintain accurate and well-formatted documentation and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have changed the content, which is out of scope of the issue. We need the page layout and page content to match the current site:
Yes just give me a minute i changes that to test if everything is working fine. |
Yes Actually i added some dummy data. And i have removed it. @palisadoes |
Yes @palisadoes I have reverted the changes. After : - |
@palisadoes |
Yes @palisadoes i get it |
I have fixed side bar border to grey. This test is failing because i have installed react-icons as we need it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
- Use the color scheme from https://hasura.io/docs/2.0/remote-schemas/overview/ when in doubt about colors for light/dark mode
- Please remove this.
- The text is unreadable in dark mode (See item 1)
- On the home screen, use a grey background (#f3f4f6). Have a div like this instead:
- The footer must use the grey (#f3f4f6) background. (See item 1 for footer text colors for this footer text)
- These also need adjustments (See item 1)
Yes @palisadoes i am doing it |
Are you still working on this? |
Yes @palisadoes i just have to commit changes. Everything is working fine |
|
The failing test is due to the fact that i installed react-icons, and we need it for styling icons. |
|
What kind of change does this PR introduce?
bugfix, feature, refactoring
Issue Number:
Fixes #3
Did you add tests for your changes?
No
Snapshots/Videos:
Before:
After:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?
Yes