-
Notifications
You must be signed in to change notification settings - Fork 203
Adding dynamic files #3754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
astro-friedel
wants to merge
95
commits into
Parsl:master
Choose a base branch
from
astro-friedel:addingDynamicFiles
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adding dynamic files #3754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le_inputs_and_outputs
initial code to handle file related monitoring messages
…t the one that used them last
benclifford
reviewed
Jan 26, 2025
benclifford
reviewed
Jan 26, 2025
benclifford
reviewed
Jan 26, 2025
benclifford
reviewed
Jan 26, 2025
benclifford
reviewed
Jan 26, 2025
benclifford
reviewed
Jan 26, 2025
benclifford
reviewed
Jan 26, 2025
benclifford
reviewed
Jan 26, 2025
benclifford
reviewed
Jan 26, 2025
benclifford
reviewed
Jan 26, 2025
benclifford
reviewed
Jan 26, 2025
…ng the future as "done"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Parsl has an issue with files that are created by an app when they are not specified in the arguments when the app is called. For example:
While
process
will properly write the log files to the list.compact
is unlikely to see them. This is because Parsl sees theoutputs
fromprocess
as an empty list and does not know that any files are actually created. This causes the constructed DAG to not create any connection betweenprocess
andcompact
, allowing them to run in parallel, instead of the expected serial.To fix this I have created the
DynamicFileList
class. This class behaves just like a list, but is also a future. Ifoutp
in the above example is an instance of this class, then Parsl will know that there are files being created and will make a dependency in the DAG forcompact
, forcing it to not execute untilprocess
is complete.There is also a new wrapper in apps called the
bash_watcher
. This wrapper was created as a way to implement usingDynamicFileLists
withbash_apps
.Changed Behaviour
Using the
DynamicFileList
class will allow for the user to write code which has an unknown number of outputs be properly tracked and linked, and run as expected.Type of change
Choose which options apply, and delete the ones which do not apply.