Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect change in CPAN releasor #22926

Open
wants to merge 1 commit into
base: blead
Choose a base branch
from

Conversation

jkeenan
Copy link
Contributor

@jkeenan jkeenan commented Jan 17, 2025

On CPAN Time-Piece has a new release from a new releasor. For consistent results out of 'Porting/core-cpan-diff', we should have changed the CPANID of the releasor in Maintainers.pl before synching. We'll correct that here and standardize all $VERSIONs in cpan/Time-Piece to indicate we're now a bit ahead of CPAN.

  • This set of changes does not require a perldelta entry.

On CPAN Time-Piece has a new release from a new releasor.  For
consistent results out of 'Porting/core-cpan-diff', we should have
changed the CPANID of the releasor in Maintainers.pl before synching.
We'll correct that here and standardize all $VERSIONs in cpan/Time-Piece
to indicate we're now a bit ahead of CPAN.
@jkeenan jkeenan requested a review from leonerd January 17, 2025 20:08
@leonerd
Copy link
Contributor

leonerd commented Jan 17, 2025

I don't get why we need to bump these all to an _01 version. Is it not sufficient simply to change the user ID in Maintainers.pl?

I was slightly surprised that it didn't update that when I ran sync-with-cpan myself in fact.

@jkeenan
Copy link
Contributor Author

jkeenan commented Jan 18, 2025

I don't get why we need to bump these all to an _01 version. Is it not sufficient simply to change the user ID in Maintainers.pl?

It might be "sufficient" with respect to getting the porting tests to DWIM. But if we were to do that, at some point in the future someone would ask, "Why is the version number in Maintainers.pl different from that in the code?"

I think our criterion here should be "What will cause the least confusion going forward?" (I acknowledge that some may feel the criterion should be "What entails the fewest changed keystrokes.)

I was slightly surprised that it didn't update that when I ran sync-with-cpan myself in fact.

This is a small flaw with sync-with-cpan that you become sensitized to once you've run the program several times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants