Document STATIC_ASSERT; add STATIC_ASSERT_EXPR and use it #23627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are now enough items, that sorting is helpful to reading
khwilliamson
force-pushed
the
static_assert
branch
from
ad47199 to
407c99c
Compare
The next commit will want this
I think these are useful and stable enough to make public
I found these useful in understanding it
These make things a bit clearer by not putting so much in each macro
This new type of a STATIC_ASSERT is used where an expression can go; hence potentially in macro expansions. Since it is compile-time, it can't be used on arguments that are expressions with side effects, so can safely be used in macros. It has limitations however, only reaching full parity when gcc brace groups are enabled, turning into an ASSUME which is a no-op in the worst case. However, most code will get compiled on a platform with gcc brace groups, and will pass or fail at compile time; so the chances of something bad actually getting into the field are minimal.
This makes sure that the argument whose pointer is being passed has the correct size to be settable by the called element.
khwilliamson
force-pushed
the
static_assert
branch
from
407c99c to
3c81bbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The STATIC_ASSERT macros are useful and have been stable for long enough to be made API.
This also adds
STATIC_ASSERT_EXPRsuitable for use in macros. It doesn't achieve parity with the others except on systems where gcc brace groups are used, falling back to less or no checking otherwise. But that's good enough to be useful and any problems will be caught when the code is attempted to be compiled on a brace group platform.