Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return zone hvac mode hvac action when in single zone mode #362

Merged
merged 1 commit into from
Feb 16, 2025
Merged

Return zone hvac mode hvac action when in single zone mode #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions custom_components/lennoxs30/climate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,8 +367,6 @@ def current_humidity(self):
@property
def hvac_mode(self):
"""Return the current hvac operation mode."""
if self.is_zone_disabled:
return None
r = self._zone.getSystemMode()
if r == LENNOX_HVAC_HEAT_COOL:
r = HVACMode.HEAT_COOL
Expand Down Expand Up @@ -481,8 +479,6 @@ async def async_set_hvac_mode(self, hvac_mode: str) -> None:
@property
def hvac_action(self):
"""Return the current hvac state/action."""
if self.is_zone_disabled:
return None
to = self._zone.tempOperation
ho = self._zone.humOperation
if to != LENNOX_TEMP_OPERATION_OFF:
Expand Down
5 changes: 3 additions & 2 deletions tests/test_climate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1000,7 +1000,7 @@ async def test_climate_hvac_mode(hass, manager_mz: Manager):

system.zoningMode = LENNOX_ZONING_MODE_CENTRAL
assert c.hvac_mode == HVACMode.HEAT
assert c1.hvac_mode is None
assert c1.hvac_mode == HVACMode.COOL


@pytest.mark.asyncio
Expand Down Expand Up @@ -1137,7 +1137,8 @@ async def test_climate_hvac_action(hass, manager_mz: Manager):
assert c.hvac_action == "unexpected_humdity_operation"

system.zoningMode = LENNOX_ZONING_MODE_CENTRAL
assert c.hvac_action is None
zone.tempOperation = LENNOX_TEMP_OPERATION_COOLING
assert c.hvac_action == HVACAction.COOLING


@pytest.mark.asyncio
Expand Down
Loading