Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Updated event emission logic and patched testing utilities #17655

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dweepvira
Copy link

This PR introduces an event listener to enhance event emission handling in Prefect. The key changes include:

  1. Added a new event listener file (event_listener.py) to streamline event handling.
  2. Modified event emission logic to ensure accurate tracking and triggering.

Testing
I attempted to run the tests but faced issues due to missing dependencies (opentelemetry.sdk, respx, etc.). Since the tests couldn’t be executed successfully, I recommend maintainers verify them before merging.

Additional Notes

  1. This is my first PR, so if there are any issues, please feel free to let me know—I’d love to learn and improve!
  2. If any changes are required in the test setup, I’m happy to update them.

Changes documented if necessary

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Copy link

codspeed-hq bot commented Mar 31, 2025

CodSpeed Performance Report

Merging #17655 will not alter performance

Comparing dweepvira:fix-event-emission (867d755) with main (d56349e)

Summary

✅ 2 untouched benchmarks

@desertaxle
Copy link
Member

Thanks for the PR @dweepvira! It's not clear to me what problem you're trying to solve with this PR. If there's an enhancement you're looking to implement, could you open an issue with a description of your proposed enhancement? That'll give us a chance to discuss and decide on an approach before implementation.

@zzstoatzz zzstoatzz marked this pull request as draft April 7, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants