Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment and notebook updates #9

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Environment and notebook updates #9

merged 4 commits into from
Feb 29, 2024

Conversation

ktyle
Copy link
Collaborator

@ktyle ktyle commented Feb 28, 2024

Also to diagnose cookbook and other Pythia-related build errors ProjectPythia/cookbook-template#160

Copy link

github-actions bot commented Feb 28, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: c457092
✅ Deployment Preview URL: https://ProjectPythia.github.io/ERA5_interactive-cookbook/_preview/9

@ktyle ktyle changed the title Remove xarray version specification Environment and notebook updates Feb 29, 2024
@ktyle ktyle requested a review from brian-rose February 29, 2024 16:57
Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay that this cookbook is building again!

It would be great to leave a comment in the env file about why all these version pins are needed, especially if we can point to one or more upstream issues. I believe this was part of our draft Cookbook review guidelines, although we never finished formalizing those.

I'm afraid I've lost track of all the sphinx issues so I'm not sure what comments to add here.

@ktyle
Copy link
Collaborator Author

ktyle commented Feb 29, 2024

@brian-rose I've added some text in the environment file. This is still a very short-term solution, as the conda-forge dependencies with regard to pydata-sphinx-theme now require at least 0.8.0 for the environment, while the sphinx-pythia-theme requires 0.7.2. Fortunately, at least for now, installing sphnix-pythia-theme via pip downgrades pydata-sphinx-theme.

Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! That's helpful to note the specific version of sphinx-pythia-theme at issue. Hopefully we'll get back to a more sane dependency stack at some point.

@ktyle ktyle merged commit cbe2bd4 into ProjectPythia:main Feb 29, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 29, 2024
negin513 added a commit that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants