-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment and notebook updates #9
Conversation
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay that this cookbook is building again!
It would be great to leave a comment in the env file about why all these version pins are needed, especially if we can point to one or more upstream issues. I believe this was part of our draft Cookbook review guidelines, although we never finished formalizing those.
I'm afraid I've lost track of all the sphinx issues so I'm not sure what comments to add here.
@brian-rose I've added some text in the environment file. This is still a very short-term solution, as the conda-forge dependencies with regard to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! That's helpful to note the specific version of sphinx-pythia-theme at issue. Hopefully we'll get back to a more sane dependency stack at some point.
Also to diagnose cookbook and other Pythia-related build errors ProjectPythia/cookbook-template#160