Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent formatting of MS vs MS/MS resolution values in Transition Settings > Full Scan dialog #3313

Merged

Conversation

bspratt
Copy link
Member

@bspratt bspratt commented Jan 3, 2025

It's actually not possible to enter this state (inconsistent use of thousands separator) as a user, but automated testing and tutorial screen capture could do so.

image
vs
image

@bspratt bspratt requested a review from brendanx67 January 3, 2025 19:16
Copy link
Contributor

@brendanx67 brendanx67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Glad it was already wrapping everywhere else but the test setting. Thanks for renaming.

@bspratt bspratt merged commit bea602a into master Jan 4, 2025
11 checks passed
@bspratt bspratt deleted the Skyline/work/20250103_consistent_MS_MSMS_resolution_format branch January 4, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants