Skip to content

Conversation

coderZoe
Copy link

@coderZoe coderZoe commented Jul 18, 2025

渠道类型为OPENAI的情况下,我在点击模型测试,测试渠道模型的时候,如下图
image
报了反序列化的错,debug发现代码在构造openai请求参数并序列化请求为json的时候,由于GeneralOpenAIRequest的Stream为false,反序列化后会丢失该字段,部分渠道stream为空的时候默认会按流式返回,导致对于返回结果反序列化解析失败

因此最好取消Stream的json tag omitempty内容,对于stream=false的也应序列化到json

Summary by CodeRabbit

  • Bug Fixes
    • Ensured the "stream" option is always included in outgoing requests, improving consistency in request formatting.

Copy link
Contributor

coderabbitai bot commented Jul 18, 2025

Walkthrough

The GeneralOpenAIRequest struct's Stream field in dto/openai_request.go was updated to always include the Stream property in its JSON serialization, regardless of its value, by removing the omitempty tag from its struct field tag.

Changes

File(s) Change Summary
dto/openai_request.go Removed omitempty from Stream field tag in GeneralOpenAIRequest struct to always include it in JSON output.

Poem

A field once shy, now always seen,
No longer hidden, not in between.
"Stream" stands tall, both false and true,
In every JSON, it shines through.
A hop, a skip, a code so neat—
Explicit fields make bugs retreat! 🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 78fb457 and c75740c.

📒 Files selected for processing (1)
  • dto/openai_request.go (1 hunks)
🔇 Additional comments (1)
dto/openai_request.go (1)

27-27: LGTM! This change correctly addresses the deserialization issue.

Removing the omitempty tag ensures that stream=false is always explicitly included in the JSON serialization, preventing channels from incorrectly treating the absence of the field as streaming enabled. This is a targeted fix that resolves the specific issue without breaking existing functionality.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@feitianbubu
Copy link
Contributor

stream为空的时候默认会按流式返回
这个前提是不是本身就是错误的, bool为空默认是false才对, 不该惯着这样的渠道吧?

@coderZoe
Copy link
Author

stream为空的时候默认会按流式返回 这个前提是不是本身就是错误的, bool为空默认是false才对, 不该惯着这样的渠道吧?

理论是这样,但既然bool为空代表是false了,那显示false应该也没错才对。其次按上面的测试 testChannel ,代码本身的意图是想非流式请求的吧,因为响应处理都是按非流式请求来处理的,既然是非流式请求测试,那更应该把stream显示设置为false而非不设置吧,因为按现在这样 Stream bool json:"stream,omitempty" 即使想非流式请求,Stream设为false,序列化为json也会丢掉,这本身也有些不合理。

@feitianbubu
Copy link
Contributor

  1. stream是非必填字段, 不传和传false,都是代表false, 只有流式才要显示设置true
  2. 序列化丢掉默认值也是合理的,除非是指针

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants