Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ensuring that max_context_tokens is never larger than what supported by models #3519

Merged
merged 3 commits into from
Dec 11, 2024
Merged

feat: ensuring that max_context_tokens is never larger than what supported by models #3519

merged 3 commits into from
Dec 11, 2024

Conversation

jacopo-chevallard
Copy link
Collaborator

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Checklist before requesting a review

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented hard-to-understand areas
  • I have ideally added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Screenshots (if appropriate):

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 11, 2024
chloedia
chloedia approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@chloedia chloedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 11, 2024
@jacopo-chevallard jacopo-chevallard merged commit d6e0ed4 into main Dec 11, 2024
5 checks passed
@jacopo-chevallard jacopo-chevallard deleted the feat/max_context_tokens branch December 11, 2024 13:28
@StanGirard StanGirard mentioned this pull request Dec 11, 2024
Merged
StanGirard added a commit that referenced this pull request Dec 16, 2024
@StanGirard
chore(main): release core 0.0.27 (#3520)
09b4811 
🤖 I have created a release *beep* *boop*
---


##
[0.0.27](core-0.0.26...core-0.0.27)
(2024-12-16)


### Features

* ensuring that max_context_tokens is never larger than what supported
by models ([#3519](#3519))
([d6e0ed4](d6e0ed4))
* send all to megaparse_sdk
([#3521](#3521))
([e48044d](e48044d))


### Bug Fixes

* fixing errors arising when the user input contains no tasks
([#3525](#3525))
([e28f7bc](e28f7bc))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chloedia chloedia chloedia approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacopo-chevallard @chloedia