Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Northstar into temporary location before installing #456

Merged
merged 8 commits into from
Aug 2, 2023
Merged

Extract Northstar into temporary location before installing #456

merged 8 commits into from
Aug 2, 2023

Conversation

Jan200101
Copy link
Contributor

This would allow preprocessing to be done ahead of time, like moving the dll into the profile or renaming the profile.

Nothing is actually done yet, because of some missing bits in Northstar.

@Jan200101
Copy link
Contributor Author

I love when cargo fmt does one thing and then the CI says another thing. Absolutely lovely

@GeckoEidechse
Copy link
Member

I love when cargo fmt does one thing and then the CI says another thing. Absolutely lovely

You got some special formatting settings in your global config maybe?

@Jan200101 Jan200101 marked this pull request as ready for review July 30, 2023 14:18
@Jan200101 Jan200101 requested a review from GeckoEidechse August 1, 2023 13:50
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my very limited testing I didn't notice any issues so I hope it's fine ^^

@GeckoEidechse GeckoEidechse merged commit 08d066c into R2NorthstarTools:main Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants