Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ModdingLogo PNG and source #10

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Caznix
Copy link

@Caznix Caznix commented Aug 12, 2024

No description provided.

Caznix added 2 commits August 12, 2024 12:23
its all jagged close up beacause its converted from a PNG. I cleaned it manually and edited it to transform into the modding logo
@barnabwhy
Copy link

barnabwhy commented Aug 12, 2024

i think the hammer is maybe too big, and too close to the boundaries of the blue part.
also, just checking, is the hammer icon something that you made or have rights to use here?

@EM4Volts
Copy link

if you are sure u can use this icon please link the license, if u find out u are not allowed to lmk and i can easily make u a hammer svg in a couple minutes

@Caznix
Copy link
Author

Caznix commented Aug 12, 2024

if you are sure u can use this icon please link the license, if u find out u are not allowed to lmk and i can easily make u a hammer svg in a couple minutes

i think the hammer is maybe too big, and too close to the boundaries of the blue part. also, just checking, is the hammer icon something that you made or have rights to use here?

The hammer was from iconior: https://iconoir.com/ iconoir is open source

i modified it myself in figma, if need be i can make edits to the SVG as needed

@barnabwhy
Copy link

barnabwhy commented Aug 12, 2024

The hammer was from iconior: https://iconoir.com/ iconoir is open source

looking up hammer on iconoir, that doesn't appear to be the same icon.

after making my original comment i did some searching on google and it appears to actually be the ra-hammer icon from rpg-awesome which is licensed under the BSD 2-Clause license and uses assets from https://game-icons.net/

the closest matching icon on game-icons.net is licensed under CC-BY 3.0, which requires attribution to be given

preferably we'd avoid using pre-existing assets which may have restrictions on their use as it allows more freedom to us

I won't personally say it's not allowed to be used, since the license does permit us to use it (so long as attribution is given) but I'll leave a decision on it up to @GeckoEidechse

@Caznix
Copy link
Author

Caznix commented Aug 12, 2024

The hammer was from iconior: https://iconoir.com/ iconoir is open source

looking up hammer on iconoir, that doesn't appear to be the same icon.

after making my original comment i did some searching on google and it appears to actually be the ra-hammer icon from rpg-awesome which is licensed under the BSD 2-Clause license and uses assets from https://game-icons.net/

the closest matching icon on game-icons.net is licensed under CC-BY 3.0, which requires attribution to be given

preferably we'd avoid using pre-existing assets which may have restrictions on their use as it allows more freedom to us

I won't personally say it's not allowed to be used, since the license does permit us to use it (so long as attribution is given) but I'll leave a decision on it up to @GeckoEidechse

Hm. I got it from an built in "Iconior" frontend on figma. Perhaps I'll have to be more careful next time

When I'm home I'll create my own hammer icon to avoid that entirely

@GeckoEidechse
Copy link
Member

When I'm home I'll create my own hammer icon to avoid that entirely

Yeah probably the easiest solution. Like I don't expect anyone going after us for using an asset without appropriate credit but it's always better to be safe then sorry and so it's always better to be extra cautious if we can ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants