[EdfColorDay Bridge] add new bridge #4370
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request artifacts
last change: Monday 2024-12-16 17:52:39 |
dvikan
reviewed
Jan 2, 2025
| { | ||
| // Set the locale to French | ||
| setlocale(LC_TIME, 'fr_FR.UTF-8'); | ||
|
|
There was a problem hiding this comment.
Please do not change locale. Can you find another way?
dvikan
reviewed
Jan 2, 2025
| $contract = $this->getKey('contract'); | ||
|
|
||
| $header = [ | ||
| 'Content-type: application/json', |
There was a problem hiding this comment.
This is wrong. This is the content type of the data in the http request. There is none body in request.
You probably meant to use Accept?
See https://stackoverflow.com/questions/35722586/http-headers-accept-and-content-type-in-a-rest-context
dvikan
reviewed
Jan 2, 2025
| */ | ||
| private function tempo(string $json): void | ||
| { | ||
| $jsonDecoded = json_decode($json, true, 512, JSON_THROW_ON_ERROR); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm adding a new bridge to be able to get the color of the current day and the next day.
Info are based on RTE data: https://www.services-rte.com/fr/visualisez-les-donnees-publiees-par-rte/calendrier-des-offres-de-fourniture-de-type-tempo.html
Screenshot: