Fix bug due to typo in async pagination of entitlements loop #10051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbstractUmbra
changed the title
|
`SKU.subscriptions`` has same problem: https://github.com/Rapptz/discord.py/blob/master/discord/sku.py#L242 (no idea how I did not noticed this before) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A help thread in the discord.py server raised a potential issue with the
Client.entitlementsmethod only returning a maximum of 100 entries.Having investigated I found this typo which would result in only 1 iteration ever (as a limit of maximum 100) will ALWAYS result in a
lenof less than 1000.NOTE: unable to test entitlements due to not having any public nor monetized bots.
Checklist