Validation fix for PluginManager in newer LPX and macOS meters fix #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, great plugin! Thanks :)
I cloned the repo and ran it in LPX 10.8.1 (newest) but it crashed in the validation:
1 Channel Test:
Render Test at 512 frames
JUCE Assertion failure in PluginProcessor.h:177
JUCE Assertion failure in juce_AudioSampleBuffer.h:255
validation result: crashed validation
So I went into debug mode and found that in validation, (at least in LPX newer versions), we need to check for a stereo channel, otherwise just set it to mono.
Then for the rendering of the meters on macOS.
I found that the buffer for the FIFO in PluginProcessor.h wasn't either pushed or pulled, it was was always empty so it didn't have anything to render, this fixes that.
Then the Goniometer::update was never called anywhere so I placed it in the timerCallback passing the buffer. Hope that's reasonble.
Last, when I changed the buffer size in AUAudioFilePlayer in AudioPluginHost to something smaller than 256, neither Histogram or Goniometer didn't render anything. However, I found you had an if-statement to render specifics for that. I guess you have some great ideas for it but I removed it since it didn't make much sense.
Also in the Goniometer::update method, I changed it up to dynamically resize the internalBuffer to whatever the host is using.