add toRelLiteral (aka RelSON)
#49
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Denis Gursky <denis.gursky@relational.ai>
|
@denisgursky, what was the API you mentioned in the call that this should use? |
https://github.com/RelationalAI/rai-sdk-javascript/blob/main/src/results/resultUtils.ts#L462 |
vilterp
commented
Aug 24, 2022
| @@ -462,6 +462,7 @@ export function convertValue<T extends RelTypedValue>( | |||
| export function getDisplayValue( | |||
| typeDef: RelTypeDef, | |||
| value: RelTypedValue['value'], | |||
| quoteStrings = false, | |||
There was a problem hiding this comment.
TODO: duplicate this whole function instead of adding this arg? https://relationalai.slack.com/archives/C02C9AV2LL9/p1661370165042819?thread_ts=1661274493.782329&cid=C02C9AV2LL9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from @denisgursky in Slack: https://relationalai.slack.com/archives/C02C9AV2LL9/p1661347284228579?thread_ts=1661274493.782329&cid=C02C9AV2LL9
TODO:
getDisplayValue^Foo[…]for value types?Co-Authored-By: Denis Gursky denis.gursky@relational.ai