Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AbstractRipper2 that uses a Custom Observer interface #2099

Closed
wants to merge 1 commit into from

Conversation

Thedrogon
Copy link
Contributor

@Thedrogon Thedrogon commented Feb 7, 2025

Added AbstractRipper2 that uses a Custom Observer interface replacing java. util. Observe which is deprecated
Added the tests that are similar to the former one , and the tests passed successfully.

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

  • a bug fix (Fix #...)
  • a new Ripper
  • a refactoring
  • a style change/fix
  • a new feature

Description

Please add details about your change here.

Testing

Required verification:

  • I've verified that there are no regressions in gradlew test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

@metaprime
Copy link
Contributor

I don't understand what problem you're trying to solve. Why re-write the ripper? Moreover, why add a new class? What did this accomplish? What's the functional improvement?
We've already discussed the deprecated java.util.Observer issue. The only reason it's deprecated is because it's supposedly not featureful enough. Your replacement is no more featureful. You're just rewriting for the sake of rewriting and not solving any problem. We like to avoid changing things that work because we don't have the time to maintain it
from what I can tell the new AbstractRipper2 hasn't been hooked up to anything
As far as I can tell this change doesn't work and/or doesn't achieve anything.

@Thedrogon
Copy link
Contributor Author

@metaprime You are right, these changes arent that important

@Thedrogon Thedrogon closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants