[Bazel examples] Use prefer_pic_for_opt_binaries #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drake upstream has switched to using prefer_pic_for_opt_binaries, which supplants --force_pic (and avoids the platform-specific logic of when to use it). Downstream users must also apply it to their own builds.
tyler-yankee
commented
Jul 15, 2025
There was a problem hiding this comment.
+@jwnimmer-tri for review, please.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee jwnimmer-tri, platform LGTM missing (waiting on @jwnimmer-tri)
a discussion (no related file):
Let's land the Drake change before landing this one.
jwnimmer-tri
requested changes
Aug 10, 2025
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, LGTM missing from assignee jwnimmer-tri, platform LGTM missing
a discussion (no related file):
Working
Let's wait for bazelbuild/rules_cc#456 to land upstream and be released, before we land this DEE change.
(Note that Drake's MODULE.bazel injection of the patch fix doesn't inherit downstream; it's a Drake-first-party-only change.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drake upstream has switched to using prefer_pic_for_opt_binaries, which supplants --force_pic (and avoids the platform-specific logic of when to use it). Downstream users must also apply it to their own builds.
Closes #20336.
This change is