[pull] development from tari-project:development #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Adds merge mining support for p2pool --------- Co-authored-by: SW van Heerden <swvheerden@gmail.com>
Description --- remove sub repo from repository
Description --- Added network wire byte. This is now independent of the network as byte. Note: This method in favour of #6502. Motivation and Context --- Base nodes and wallets maintained numerous connections from which they could not sync or obtain useful information. This caused base nodes to try and follow other base nodes that were on a higher proof of work but on a different genesis block, and caused wallets to query base nodes that supplied information from a different blockchain. This byte can now be changed every time the genesis block changes. How Has This Been Tested? --- Passed all unit tests. What process can a PR reviewer use to test or verify this change? --- <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [X] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer -->
Description Document a single line docker command for ledger_wallet firmware build Motivation and Context Easy to follow instructions How Has This Been Tested? Tested run command locally Co-authored-by: SW van Heerden <swvheerden@gmail.com>
…6520) Description Archive and checksum minotari_ledger_wallet for release Add best effort build option Motivation and Context Include minotari_ledger_wallet assets in release How Has This Been Tested? Builds in local fork
… p2pool proto (#6509) Description --- Added PoW algo to p2pool client request, so clients can get a SHA-3 or Random-X block to mine on. Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify
Description --- reduces unnecessary logs Motivation and Context --- We should not log everything that happens on debug. These logs are also only logged on certain cfg flags.
Add a new file for grpc requests
Description --- Add paper wallet to console wallet Add scrape wallet to wallet FFI Motivation and Context --- This will allow you to import a paper wallet to your own wallet How Has This Been Tested? --- Manual
Description --- Add missing parameters for merge mining proxy to use p2pool. Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify --------- Co-authored-by: SW van Heerden <swvheerden@gmail.com>
remove sub repo
Description --- New release for esme with a new gen block and a new wirebyte
Description --- Cleared handshake error form the client side by forcefully disconnecting form the peer. Motivation and Context --- This is to syop the phenomenon whereby a peer can dial another peer (`dial-eer XXXXX`) but cannot ping that same peer (`ping-peer XXXXX`). (See #6516) How Has This Been Tested? --- Unit tests pass Long-term system-level testing has to be done to confirm this solved the issue. What process can a PR reviewer use to test or verify this change? --- Review code changes. <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
Description --- Propagate handshake error to next process. This was omitted in #6528. Motivation and Context --- See above. How Has This Been Tested? --- System-level testing. What process can a PR reviewer use to test or verify this change? --- Code review. <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
Description --- Added console wallet detail: - Receive tab: `Node ID` => `Node ID / Public key` - Network tab: `Type, Public key` => `Type, Node ID, Public key` Motivation and Context --- To provide more useable information. How Has This Been Tested? --- System-level testing. What process can a PR reviewer use to test or verify this change? --- Code review, system-level testing. <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
Description --- Improved test coverage for genesis block sanity checks when run locally in debug or release mode. This PR removed the need for `fn XXXX_genesis_sanity_check()` tests to be compiled for a specific target network, and for the global static network variable to be set for a target network, i.e. `let _ = Network::set_current(Network::Esmeralda);`. `cargo.exe test --release --lib blocks::genesis_block` will now run all 6x tests serially . This also works in a CI environment where `cargo nextest` is called, without any impact on overall runtime performance. Motivation and Context --- All 6x `fn XXXX_genesis_sanity_check()` tests could not be run with a single target network build. How Has This Been Tested? --- Locally and on CI. What process can a PR reviewer use to test or verify this change? --- - Review code changes - Review CI unit test output where all 6x tests in question should be executed in a single test run:  <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
Description --- - Improved universe comms by defaulting to bypass tor for outbound tcp connections. - Refrain from dialling tcp 'ConnectionManagerConfig::default().listener_address' Motivation and Context --- We need to improve Universe connectivity. How Has This Been Tested? --- Unit tests pass System-level testing [**TBD**] What process can a PR reviewer use to test or verify this change? --- Code review <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
Description --- new release
Description --- Minor changes of interface needed for the randomx miner. Motivation and Context --- So the randomx miner can work mo' betta How Has This Been Tested? --- Tested alongside the miner locally.
Description --- Reduce universe spam logs Motivation and Context --- To much spam logs How Has This Been Tested? --- Unit tests What process can a PR reviewer use to test or verify this change? --- Code review <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
Description Add quay expire for none release docker images Motivation and Context Save store by expiring older test images How Has This Been Tested? Built and noted expiry of older images in local fork
Proxy config would generate 200mb files that are impossible to read in an editor
Description --- updates the nextnet change log
Description --- Changed the ledger app version check from an explicit check to a min version check Uses semver for checking Closes: #6439
Description --- Block use of interactive only address from being used in coinbase builder
Description --- Currently get_address grpc call only returns the interactive address. This adds the one-sided address as well, showing both.
Description --- Displays waiting for initial peer data on the status string Motivation and Context --- better info for the user: 
Changed the level of some logs in mmproxy
Description --- reset network <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Updated genesis block creation with a new timestamp and computed values, replacing previous temporary workarounds. - **Refactor** - Standardized block validations to ensure all blocks are thoroughly and uniformly checked. - **Chores** - Adjusted network identification settings to enhance compatibility and communication across supported networks. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description --- new release esme <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated version numbers across core components. - Revised documentation to reflect new recommended network versions. - **Bug Fixes** - Enhanced system stability with refined operating mode validation. - Patched a security vulnerability and streamlined legacy data handling. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description --- fix libtor data dir override, which clashed with the log dir short option `-l` Suppress warning about chain metadata not existing on startup <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Updated a command-line option to now use a distinct short flag, enhancing clarity in the CLI interface. - **Bug Fixes** - Introduced a brief delay before error messaging for chain metadata, reducing premature warnings during startup. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description --- Removes old and wrong content in the readme <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Documentation** - Updated test instructions to require the nightly version for proper execution. - Simplified guidelines for starting services, including streamlined directions for Tor startup. - Streamlined commands for launching applications by removing outdated initialization parameters. - Revised mining protocol details to reflect a balanced 50/50 apportionment and removed obsolete configuration instructions. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Bumps [dorny/test-reporter](https://github.com/dorny/test-reporter) from 1 to 2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dorny/test-reporter/releases">dorny/test-reporter's releases</a>.</em></p> <blockquote> <h2>v2.0.0</h2> <h2>What's Changed</h2> <ul> <li>Merge v1.7.0 to v1 branche by <a href="https://github.com/j-catania"><code>@j-catania</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/298">dorny/test-reporter#298</a></li> <li>Bump development to <code>v2.0.0-preview</code> by <a href="https://github.com/jozefizso"><code>@jozefizso</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/449">dorny/test-reporter#449</a></li> <li>Update checkout and upload-artifact actions versions by <a href="https://github.com/Akaame"><code>@Akaame</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/419">dorny/test-reporter#419</a></li> <li>README.md: Update GitHub Actions by <a href="https://github.com/cclauss"><code>@cclauss</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/404">dorny/test-reporter#404</a></li> <li>Update project to Node 20 runtime by <a href="https://github.com/jozefizso"><code>@jozefizso</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/450">dorny/test-reporter#450</a></li> <li>Add support for NUnit v3 XML results files by <a href="https://github.com/kring"><code>@kring</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/225">dorny/test-reporter#225</a></li> <li>Fix JUnit message / type fields. by <a href="https://github.com/AnthonyBarbier"><code>@AnthonyBarbier</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/399">dorny/test-reporter#399</a></li> <li>Update mocha-json usage instructions by <a href="https://github.com/MonkeyDo"><code>@MonkeyDo</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/145">dorny/test-reporter#145</a></li> <li>Clarify .NET support is dotnet test command support by <a href="https://github.com/anatawa12"><code>@anatawa12</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/232">dorny/test-reporter#232</a></li> <li>Target node20 by <a href="https://github.com/jozefizso"><code>@jozefizso</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/489">dorny/test-reporter#489</a></li> <li>Support displaying test results in markdown using GitHub Actions Job Summaries by <a href="https://github.com/ritchxu"><code>@ritchxu</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/463">dorny/test-reporter#463</a></li> <li>Support displaying test results in markdown using GitHub Actions Job Summaries by <a href="https://github.com/ritchxu"><code>@ritchxu</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/383">dorny/test-reporter#383</a></li> <li>Fix parsing of ESLint reports in jest-junit format by <a href="https://github.com/phjardas"><code>@phjardas</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/134">dorny/test-reporter#134</a></li> <li>Change docs for mocha-json by <a href="https://github.com/chdanielmueller"><code>@chdanielmueller</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/517">dorny/test-reporter#517</a></li> <li>Remove unused development dependency <code>@types/github-slugger</code> by <a href="https://github.com/jozefizso"><code>@jozefizso</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/524">dorny/test-reporter#524</a></li> <li>Merge <code>v1</code> branch to <code>main</code> by <a href="https://github.com/jozefizso"><code>@jozefizso</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/525">dorny/test-reporter#525</a></li> <li>Update bug_report.md by <a href="https://github.com/j-catania"><code>@j-catania</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/553">dorny/test-reporter#553</a></li> <li>Update feature.md by <a href="https://github.com/j-catania"><code>@j-catania</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/554">dorny/test-reporter#554</a></li> <li>feat: parse junit report with message by <a href="https://github.com/cmonaghan1"><code>@cmonaghan1</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/559">dorny/test-reporter#559</a></li> <li>Update dependencies by <a href="https://github.com/jozefizso"><code>@jozefizso</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/560">dorny/test-reporter#560</a></li> <li>test-reporter release v2.0.0 by <a href="https://github.com/jozefizso"><code>@jozefizso</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/561">dorny/test-reporter#561</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/Akaame"><code>@Akaame</code></a> made their first contribution in <a href="https://redirect.github.com/dorny/test-reporter/pull/419">dorny/test-reporter#419</a></li> <li><a href="https://github.com/cclauss"><code>@cclauss</code></a> made their first contribution in <a href="https://redirect.github.com/dorny/test-reporter/pull/404">dorny/test-reporter#404</a></li> <li><a href="https://github.com/kring"><code>@kring</code></a> made their first contribution in <a href="https://redirect.github.com/dorny/test-reporter/pull/225">dorny/test-reporter#225</a></li> <li><a href="https://github.com/AnthonyBarbier"><code>@AnthonyBarbier</code></a> made their first contribution in <a href="https://redirect.github.com/dorny/test-reporter/pull/399">dorny/test-reporter#399</a></li> <li><a href="https://github.com/MonkeyDo"><code>@MonkeyDo</code></a> made their first contribution in <a href="https://redirect.github.com/dorny/test-reporter/pull/145">dorny/test-reporter#145</a></li> <li><a href="https://github.com/anatawa12"><code>@anatawa12</code></a> made their first contribution in <a href="https://redirect.github.com/dorny/test-reporter/pull/232">dorny/test-reporter#232</a></li> <li><a href="https://github.com/ritchxu"><code>@ritchxu</code></a> made their first contribution in <a href="https://redirect.github.com/dorny/test-reporter/pull/463">dorny/test-reporter#463</a></li> <li><a href="https://github.com/phjardas"><code>@phjardas</code></a> made their first contribution in <a href="https://redirect.github.com/dorny/test-reporter/pull/134">dorny/test-reporter#134</a></li> <li><a href="https://github.com/chdanielmueller"><code>@chdanielmueller</code></a> made their first contribution in <a href="https://redirect.github.com/dorny/test-reporter/pull/517">dorny/test-reporter#517</a></li> <li><a href="https://github.com/cmonaghan1"><code>@cmonaghan1</code></a> made their first contribution in <a href="https://redirect.github.com/dorny/test-reporter/pull/559">dorny/test-reporter#559</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/dorny/test-reporter/compare/v1.9.1...v2.0.0">https://github.com/dorny/test-reporter/compare/v1.9.1...v2.0.0</a></p> <h2>v1.9.1</h2> <h2>What's Changed</h2> <ul> <li>fix: reporting wrong number of tests in Dart by <a href="https://github.com/dominicmh"><code>@dominicmh</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/426">dorny/test-reporter#426</a></li> <li>Fix problematic retransmission of authentication token (alternative solution) by <a href="https://github.com/JojOatXGME"><code>@JojOatXGME</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/438">dorny/test-reporter#438</a></li> <li>Update development dependencies by <a href="https://github.com/jozefizso"><code>@jozefizso</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/442">dorny/test-reporter#442</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/dominicmh"><code>@dominicmh</code></a> made their first contribution in <a href="https://redirect.github.com/dorny/test-reporter/pull/426">dorny/test-reporter#426</a></li> <li><a href="https://github.com/JojOatXGME"><code>@JojOatXGME</code></a> made their first contribution in <a href="https://redirect.github.com/dorny/test-reporter/pull/438">dorny/test-reporter#438</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/dorny/test-reporter/compare/v1.9.0...v1.9.1">https://github.com/dorny/test-reporter/compare/v1.9.0...v1.9.1</a></p> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/dorny/test-reporter/blob/main/CHANGELOG.md">dorny/test-reporter's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <h2>2.0.0</h2> <ul> <li>Parse JUnit report with detailed message in failure <a href="https://redirect.github.com/dorny/test-reporter/pull/559">dorny/test-reporter#559</a></li> <li>Support displaying test results in markdown using GitHub Actions Job Summaries <a href="https://redirect.github.com/dorny/test-reporter/pull/383">dorny/test-reporter#383</a></li> </ul> <h2>1.9.1</h2> <ul> <li>Fix problematic retransmission of authentication token <a href="https://redirect.github.com/dorny/test-reporter/pull/438">dorny/test-reporter#438</a></li> <li>Report correct number of tests in Dart <a href="https://redirect.github.com/dorny/test-reporter/pull/426">dorny/test-reporter#426</a></li> <li>Number of completed tests mismatches passed/failed <a href="https://redirect.github.com/dorny/test-reporter/issues/319">dorny/test-reporter#319</a></li> </ul> <h2>1.9.0</h2> <ul> <li>Add support for Rspec (Ruby) <a href="https://redirect.github.com/dorny/test-reporter/pull/398">dorny/test-reporter#398</a></li> </ul> <h2>1.8.0</h2> <ul> <li>Add <code>SwiftXunitParser</code> class based on <code>JavaJunitParser</code> for <code>swift-xunit</code> reporter <a href="https://redirect.github.com/dorny/test-reporter/pull/317">dorny/test-reporter#317</a></li> <li>Use NodeJS 18 LTS as default runtime <a href="https://redirect.github.com/dorny/test-reporter/pull/332">dorny/test-reporter#332</a></li> <li>Escape <code><></code> characters in suite name <a href="https://redirect.github.com/dorny/test-reporter/pull/236">dorny/test-reporter#236</a></li> <li>Update actions runtime to Node20 <a href="https://redirect.github.com/dorny/test-reporter/pull/315">dorny/test-reporter#315</a></li> <li>Update check title and remove icon <a href="https://redirect.github.com/dorny/test-reporter/pull/144">dorny/test-reporter#144</a></li> </ul> <h2>1.7.0</h2> <ul> <li>Fix <a href="https://redirect.github.com/dorny/test-reporter/issues/199">#199</a>: Use ✅ instead of ✔️ for better cross platform look by <a href="https://github.com/petrdvorak"><code>@petrdvorak</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/200">dorny/test-reporter#200</a></li> <li>Verify content of dist/ folder matches build output by <a href="https://github.com/dorny"><code>@dorny</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/207">dorny/test-reporter#207</a></li> <li>Gracefully handle empty nested testsuite elements for JUnit. by <a href="https://github.com/rvdlaarschot"><code>@rvdlaarschot</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/193">dorny/test-reporter#193</a></li> <li>Gracefully handle empty failure tags by <a href="https://github.com/haudren-woven"><code>@haudren-woven</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/213">dorny/test-reporter#213</a></li> <li>Fix <a href="https://redirect.github.com/dorny/test-reporter/issues/208">#208</a> - java-junit: show annotations on PR changed files by <a href="https://github.com/atsu85"><code>@atsu85</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/209">dorny/test-reporter#209</a></li> <li>Only report failure if fail-on-error is set by <a href="https://github.com/trond-snekvik"><code>@trond-snekvik</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/214">dorny/test-reporter#214</a></li> <li>Improve clarity on configuring for forkable repos by <a href="https://github.com/abelbraaksma"><code>@abelbraaksma</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/211">dorny/test-reporter#211</a></li> <li>Suppress "Processing test results from" log by <a href="https://github.com/vasanthdharmaraj"><code>@vasanthdharmaraj</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/179">dorny/test-reporter#179</a></li> <li>Skip listing of files if error parsing is disabled by <a href="https://github.com/dorny"><code>@dorny</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/216">dorny/test-reporter#216</a></li> <li>Correct typo in docs by <a href="https://github.com/tangowithfoxtrot"><code>@tangowithfoxtrot</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/254">dorny/test-reporter#254</a></li> <li>update dependencies by <a href="https://github.com/j-catania"><code>@j-catania</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/269">dorny/test-reporter#269</a></li> <li>Add permissions to example yml files by <a href="https://github.com/TurnrDev"><code>@TurnrDev</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/263">dorny/test-reporter#263</a></li> <li>add feature fail-on-empty by <a href="https://github.com/gdams"><code>@gdams</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/243">dorny/test-reporter#243</a></li> <li>Add dependabot configuration by <a href="https://github.com/yeikel"><code>@yeikel</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/228">dorny/test-reporter#228</a></li> <li>Bump ws from 7.3.1 to 7.5.9 in /reports/jest by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/265">dorny/test-reporter#265</a></li> <li>Bump actions/checkout from 2 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/279">dorny/test-reporter#279</a></li> <li>Add new output for url url html by <a href="https://github.com/luisito666"><code>@luisito666</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/242">dorny/test-reporter#242</a></li> <li>Update README.md by <a href="https://github.com/IanMoroney"><code>@IanMoroney</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/158">dorny/test-reporter#158</a></li> <li>Update jest-Junit part of Readme by <a href="https://github.com/ryancasburn-KAI"><code>@ryancasburn-KAI</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/176">dorny/test-reporter#176</a></li> <li>fix: default-valued fields are not mandatory by <a href="https://github.com/TomerFi"><code>@TomerFi</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/172">dorny/test-reporter#172</a></li> <li>Bump ansi-regex from 4.1.0 to 4.1.1 in /reports/jest by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/278">dorny/test-reporter#278</a></li> <li>Bump decode-uri-component from 0.2.0 to 0.2.2 in /reports/jest by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/276">dorny/test-reporter#276</a></li> <li>Bump minimist from 1.2.5 to 1.2.8 in /reports/jest by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/275">dorny/test-reporter#275</a></li> <li>Bump qs from 6.5.2 to 6.5.3 in /reports/jest by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/272">dorny/test-reporter#272</a></li> <li>Bump json5 from 2.1.3 to 2.2.3 in /reports/jest by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/271">dorny/test-reporter#271</a></li> <li>Bump ansi-regex from 3.0.0 to 3.0.1 in /reports/mocha by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/270">dorny/test-reporter#270</a></li> <li>declare 'url' and 'url_html' as action outputs by <a href="https://github.com/micha-one"><code>@micha-one</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/287">dorny/test-reporter#287</a></li> <li>Avoid split on undefined by <a href="https://github.com/cazou"><code>@cazou</code></a> in <a href="https://redirect.github.com/dorny/test-reporter/pull/258">dorny/test-reporter#258</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dorny/test-reporter/commit/6e6a65b7a0bd2c9197df7d0ae36ac5cee784230c"><code>6e6a65b</code></a> test-reporter release v2.0.0</li> <li><a href="https://github.com/dorny/test-reporter/commit/3bd727259afe0d75d3d227567c5f00fda9c0efab"><code>3bd7272</code></a> test-reporter release v2.0.0</li> <li><a href="https://github.com/dorny/test-reporter/commit/5c0d9a463aff27dcfe458ed040ebc2441c9b6624"><code>5c0d9a4</code></a> Merge pull request <a href="https://redirect.github.com/dorny/test-reporter/issues/560">#560</a> from jozefizso/update_packages</li> <li><a href="https://github.com/dorny/test-reporter/commit/613e721b02367319f23491b4e09edc78202a19a9"><code>613e721</code></a> Update development dependencies</li> <li><a href="https://github.com/dorny/test-reporter/commit/f4ba16072c5a7dc43e75066fbdb184bec8759100"><code>f4ba160</code></a> Update production dependencies</li> <li><a href="https://github.com/dorny/test-reporter/commit/27dd4e035f1ac19950cdb31767bd94466b9ec8be"><code>27dd4e0</code></a> Merge pull request <a href="https://redirect.github.com/dorny/test-reporter/issues/559">#559</a> from cmonaghan1/feat/support-junit-report-with-message</li> <li><a href="https://github.com/dorny/test-reporter/commit/10d304d4fbfa8829fbe4e645416dbeeaf8bea32a"><code>10d304d</code></a> build: recompile production code</li> <li><a href="https://github.com/dorny/test-reporter/commit/70db77d88c30cc30674e126944fd6716ba0137d8"><code>70db77d</code></a> feat: parse junit report with message</li> <li><a href="https://github.com/dorny/test-reporter/commit/41662db5cae40449eff81c63a9a8d0a8c34694bf"><code>41662db</code></a> Merge pull request <a href="https://redirect.github.com/dorny/test-reporter/issues/554">#554</a> from dorny/j-catania-patch-1</li> <li><a href="https://github.com/dorny/test-reporter/commit/472c8c84b3bbb5d4140684812eb8d0062d1812d9"><code>472c8c8</code></a> Update feature.md</li> <li>Additional commits viewable in <a href="https://github.com/dorny/test-reporter/compare/v1...v2">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Description --- Coinbases counts are checked as part of validation. They are not checked as part of new block template creation. This checks the consensus as part of creation so as to stop miners from create invalid blocks <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Enhanced error handling for coinbase entry limits during block template and block creation. Users will receive a clear error message if the number of coinbase entries exceeds the allowed limit, ensuring adherence to consensus rules. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated logging configuration to include console output and tuned verbosity levels, delivering more user-friendly and context-rich error messages that enhance troubleshooting and diagnostics. - **Style** - Refined code formatting by consolidating and reorganizing redundant elements, resulting in improved readability and maintainability. These internal adjustments strengthen the system foundation without impacting existing functionality. - **Bug Fixes** - Adjusted logging levels to provide clearer insights into the system's operations, enhancing the visibility of important events during execution. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - The network state now reports the current number of active peer connections, giving users improved visibility into connectivity. - A new field for the number of connections has been added to the network state response. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description --- Fixes the startup arg of libtor data dir. This clashes with the log dir by default. This changes libtor to rather use `-z` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved the command-line interface by introducing a dedicated shortcut for specifying the data directory. The option now requires using an explicit “-z” flag, enhancing clarity and consistency when launching the tool. Users will enjoy the same underlying functionality with a more intuitive flag for accessing the data directory. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Users are now prompted for necessary gRPC addresses during configuration if not already provided. - **Refactor** - Streamlined address handling by switching from a complex multi-address approach to a simpler string-based method. - Simplified connection workflows and endpoint initialization across components. - **Chores** - Updated dependencies with explicit versions and features. - Refined logging output to include additional context while reducing verbosity. - **Bug Fixes** - Corrected the format of gRPC addresses from TCP to HTTP for improved connectivity. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: SW van Heerden <swvheerden@gmail.com> Co-authored-by: Hansie Odendaal <39146854+hansieodendaal@users.noreply.github.com> Co-authored-by: brianp <brian.o.pearce@gmail.com> Co-authored-by: Brian Pearce <brianp@users.noreply.github.com>
Description --- Fixes sync peer order to ensure it picks the best peer <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced peer creation to allow specifying accumulated difficulty, with a reliable default when no value is provided. - **Refactor** - Improved the sorting logic to ensure peers are ordered accurately based on their accumulated difficulty. - **Tests** - Added validation to confirm that peers are sorted correctly by their accumulated difficulty values. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description --- Make sure the can we modify SMT is access inside of the write lock <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved internal process flow to enhance consistency without affecting any visible functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description --- In the minotari_console_wallet, the excess signature was displayed in the incorrect order, with the nonce appearing as the signature and the signature appearing as the nonce * from _applications/minotari_console_wallet/src/ui/state/app_state.rs_ (https://github.com/tari-project/tari/blob/61eda049cdd8a437cd673897816e8d4628a6fa31/applications/minotari_console_wallet/src/ui/state/app_state.rs#L1195) ``` let excess_signature = format!( "{},{}", tx.transaction .first_kernel_excess_sig() .map(|s| s.get_signature().to_hex()) .unwrap_or_default(), tx.transaction .first_kernel_excess_sig() .map(|s| s.get_compressed_public_nonce().to_hex()) .unwrap_or_default() ); ``` * from _applications/minotari_console_wallet/src/ui/components/transactions_tab_ (https://github.com/tari-project/tari/blob/development/applications/minotari_console_wallet/src/ui/components/transactions_tab.rs#L338) ``` let excess_sig = Span::styled("Excess sig(nonce, sig):", Style::default().fg(Color::Magenta)); ``` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Style** - Updated a label in the transactions view to display parameters in a clearer, more logical order (“Excess sig(sig, nonce):”), enhancing the overall readability of transaction details. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
New esme release
Description --- Added display info to yamux worker. Motivation and Context --- We need more info on yamux stream errors. How Has This Been Tested? --- System-level testing This ``` 2025-04-01 16:02:10.204741000 [comms::multiplexing::yamux] DEBUG 0 Incoming peer substream ended. ``` now changed to ``` 2025-04-01 16:03:58.580227900 [comms::multiplexing::yamux] DEBUG 2 Incoming peer (PeerConnectionInfo( public_key: 248e3bcc174d0a8e63a6fe611dcb4ecb814edd84b5503be3edbe5a79475ae760, node_id: 074b18bfd54e1680907e7da588, features: PeerFeatures(MESSAGE_PROPAGATION | DHT_STORE_FORWARD), user_agent: tari/basenode/1.13.0-rc.0)) substream ended. ``` What process can a PR reviewer use to test or verify this change? --- Code review. <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Enhanced the connection upgrade process by integrating additional connection metadata, including public key, features, and user agent, providing clearer diagnostics and logging for better visibility during peer communication. - **Refactor** - Streamlined connection handling to seamlessly incorporate the enriched metadata throughout the connection upgrade workflow. - **Bug Fixes** - Removed the `shutdown_signal` from the `Inbound` struct initialization, refining its shutdown management behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description
---
Removed memory allocation for MaxSizeVec
Motivation and Context
---
Inefficient memory use when loading many blocks - see below memory usage
of empty covenants
- `tari_core::covenants::covenant::Covenant::from_bytes`
- `tari_script::script::TariScript::from_bytes`
```
▼ PP 1/1 (2 children) {
Total: 41,432,753,986 bytes (100%, 69,571,652.29/s) in 108,158,114 blocks (100%, 181,613.29/s), avg size 383.08 bytes, avg lifetime 120,597,513.57 µs (20.25% of program duration)
At t-gmax: 22,499,253,266 bytes (100%) in 49,275,839 blocks (100%), avg size 456.6 bytes
At t-end: 282,701 bytes (100%) in 422 blocks (100%), avg size 669.91 bytes
Allocated at {
#0: [root]
}
}
├─▼ PP 1.1/2 (10 children) {
│ Total: 41,432,474,135 bytes (100%, 69,571,182.38/s) in 108,121,152 blocks (99.97%, 181,551.22/s), avg size 383.2 bytes, avg lifetime 120,638,475.88 µs (20.26% of program duration)
│ At t-gmax: 22,499,250,494 bytes (100%) in 49,275,795 blocks (100%), avg size 456.6 bytes
│ At t-end: 279,339 bytes (98.81%) in 375 blocks (88.86%), avg size 744.9 bytes
│ Allocated at {
│ #1: 0x7ff6654e0148: <dhat::Alloc as core::alloc::global::GlobalAlloc>::alloc (???:0:0)
│ }
│ }
│ ├─▶ PP 1.1.1/10 (5 children) {
│ │ Total: 1,150,169,792 bytes (2.78%, 1,931,303.26/s) in 35,942,806 blocks (33.23%, 60,353.23/s), avg size 32 bytes, avg lifetime 144,977,955.4 µs (24.34% of program duration)
│ │ At t-gmax: 629,866,560 bytes (2.8%) in 19,683,330 blocks (39.95%), avg size 32 bytes
│ │ At t-end: 0 bytes (0%) in 0 blocks (0%), avg size 0 bytes
│ │ Allocated at {
│ │ ^1: 0x7ff6654e0148: <dhat::Alloc as core::alloc::global::GlobalAlloc>::alloc (???:0:0)
│ │ #2: 0x7ff66563b67f: <&mut bincode::de::Deserializer<R,O> as serde::de::Deserializer>::deserialize_bytes (???:0:0)
│ │ }
│ │ }
│ ├─▶ PP 1.1.2/10 (2 children) {
│ │ Total: 1,438,330,674 bytes (3.47%, 2,415,167.52/s) in 9,113,613 blocks (8.43%, 15,303.09/s), avg size 157.82 bytes, avg lifetime 142,637,345.13 µs (23.95% of program duration)
│ │ At t-gmax: 785,612,379 bytes (3.49%) in 4,908,440 blocks (9.96%), avg size 160.05 bytes
│ │ At t-end: 1,651 bytes (0.58%) in 14 blocks (3.32%), avg size 117.93 bytes
│ │ Allocated at {
│ │ ^1: 0x7ff6654e0148: <dhat::Alloc as core::alloc::global::GlobalAlloc>::alloc (???:0:0)
│ │ #2: 0x7ff6654e8117: alloc::raw_vec::finish_grow (???:0:0)
│ │ }
│ │ }
│ ├── PP 1.1.3/10 {
│ │ Total: 18,365,476,864 bytes (44.33%, 30,838,321.08/s) in 8,967,518 blocks (8.29%, 15,057.77/s), avg size 2,048 bytes, avg lifetime 144,960,289.92 µs (24.34% of program duration)
│ │ Max: 10,052,458,496 bytes in 4,908,427 blocks, avg size 2,048 bytes
│ │ At t-gmax: 10,052,458,496 bytes (44.68%) in 4,908,427 blocks (9.96%), avg size 2,048 bytes
│ │ At t-end: 0 bytes (0%) in 0 blocks (0%), avg size 0 bytes
│ │ Allocated at {
│ │ ^1: 0x7ff6654e0148: <dhat::Alloc as core::alloc::global::GlobalAlloc>::alloc (???:0:0)
│ │ #2: 0x7ff6659959a6: tari_core::covenants::covenant::Covenant::from_bytes (???:0:0)
│ │ #3: 0x7ff665639f18: <tari_core::covenants::serde::CovenantVisitor as serde::de::Visitor>::visit_bytes (???:0:0)
│ │ #4: 0x7ff66563b986: <&mut bincode::de::Deserializer<R,O> as serde::de::Deserializer>::deserialize_bytes (???:0:0)
│ │ #5: 0x7ff665637075: serde::de::Visitor::visit_i128 (???:0:0)
│ │ #6: 0x7ff66563e2bf: <&mut bincode::de::Deserializer<R,O> as serde::de::Deserializer>::deserialize_struct (???:0:0)
│ │ #7: 0x7ff66563aae0: <&mut bincode::de::Deserializer<R,O> as serde::de::Deserializer>::deserialize_seq (???:0:0)
│ │ #8: 0x7ff6656375c5: serde::de::Visitor::visit_i128 (???:0:0)
│ │ #9: 0x7ff66563f149: <&mut bincode::de::Deserializer<R,O> as serde::de::Deserializer>::deserialize_struct (???:0:0)
│ │ #10: 0x7ff665644452: <sha_p2pool::sharechain::lmdb_block_storage::LmdbBlockStorage as sha_p2pool::sharechain::lmdb_block_storage::BlockCache>::all_blocks (???:0:0)
│ │ }
│ │ }
│ ├── PP 1.1.4/10 {
│ │ Total: 2,080,464,176 bytes (5.02%, 3,493,403.56/s) in 8,967,518 blocks (8.29%, 15,057.77/s), avg size 232 bytes, avg lifetime 144,960,301.43 µs (24.34% of program duration)
│ │ Max: 1,138,755,064 bytes in 4,908,427 blocks, avg size 232 bytes
│ │ At t-gmax: 1,138,755,064 bytes (5.06%) in 4,908,427 blocks (9.96%), avg size 232 bytes
│ │ At t-end: 0 bytes (0%) in 0 blocks (0%), avg size 0 bytes
│ │ Allocated at {
│ │ ^1: 0x7ff6654e0148: <dhat::Alloc as core::alloc::global::GlobalAlloc>::alloc (???:0:0)
│ │ #2: 0x7ff6659bff4d: tari_script::op_codes::Opcode::parse (???:0:0)
│ │ #3: 0x7ff6659be753: tari_script::script::TariScript::from_bytes (???:0:0)
│ │ #4: 0x7ff66552d7b9: <tari_script::serde::<impl serde::de::Deserialize for tari_script::script::TariScript>::deserialize::ScriptVisitor as serde::de::Visitor>::visit_bytes (???:0:0)
│ │ #5: 0x7ff66563bac6: <&mut bincode::de::Deserializer<R,O> as serde::de::Deserializer>::deserialize_bytes (???:0:0)
│ │ #6: 0x7ff66563e0df: <&mut bincode::de::Deserializer<R,O> as serde::de::Deserializer>::deserialize_struct (???:0:0)
│ │ #7: 0x7ff66563aae0: <&mut bincode::de::Deserializer<R,O> as serde::de::Deserializer>::deserialize_seq (???:0:0)
│ │ #8: 0x7ff6656375c5: serde::de::Visitor::visit_i128 (???:0:0)
│ │ #9: 0x7ff66563f149: <&mut bincode::de::Deserializer<R,O> as serde::de::Deserializer>::deserialize_struct (???:0:0)
│ │ #10: 0x7ff665644452: <sha_p2pool::sharechain::lmdb_block_storage::LmdbBlockStorage as sha_p2pool::sharechain::lmdb_block_storage::BlockCache>::all_blocks (???:0:0)
│ │ }
│ │ }
```
How Has This Been Tested?
---
Not tested
What process can a PR reviewer use to test or verify this change?
---
Code review
<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->
Breaking Changes
---
- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify
<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Refactor**
- Improved dynamic memory handling to optimize resource utilization as
new data is added.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description --- - Yamux should not poll after an error. - Adds further specialization on error handling when the remote peer disconnects forcefully. Motivation and Context --- Tha yamux close was erroneously introduced in a previous PR #6904. How Has This Been Tested? --- Not tested - just reverting What process can a PR reviewer use to test or verify this change? --- Code review <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Enhanced handling of connection issues to deliver more stable and reliable network interactions. - Updated the connection closure process to better manage unexpected interruptions and reduce disruptions. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description --- fix(comms/yamux): dont poll the substream after closing/error Motivation and Context --- We inadvertently polled the connection after closing it/after an error. This is not correct and results in a panic Ref libp2p/rust-yamux#199 The PR above prevents the panic and sets the connection state to closed. This related PR can also be merged before/after this one: #6909 How Has This Been Tested? --- Not explicitly tested What process can a PR reviewer use to test or verify this change? --- <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved connection handling to prevent further processing once a connection is closed, enhancing reliability by ensuring that operations halt gracefully when encountering a closed state. - Added tracking for the closed state of the worker, enhancing robustness in connection management. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: SW van Heerden <swvheerden@gmail.com>
Description --- Atm we dont remove old seeds if we reorg the chain. If we mine a block while syncing it might be that we insert the first seen height of the monero seed way too early and thus cause the node to think the seed is too old when verifying the chain. This PR will remove seeds for blocks that have been reorged out of the chain. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new database index for improved seed height tracking, ensuring consistent management during block header deletions and insertions. - Added a conversion method to transform internal byte arrays into more flexible vector formats. - Enhanced block validation by incorporating additional checks on Monero seed height to maintain protocol integrity. - **Refactor** - Streamlined proof-of-work data verification by removing legacy logic and unnecessary parameters for a cleaner validation process. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description --- new release esmeralda
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced functionality to retrieve all stored key-value entries, enabling comprehensive data inspection. - Enhanced migration process for seed and height retrieval, improving clarity and efficiency. - **Style** - Improved code formatting and organization for consistency and enhanced readability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: SW van Heerden <swvheerden@gmail.com>
Description --- new release esme <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Incremented version numbers to 1.13.3-pre.0 across multiple components. - **Documentation** - Updated recommended network versions in the user documentation. - **New Features** - Enhanced transaction handling for one-sided payments with improved validation and metadata support. - **Bug Fixes** - Fixed a migration issue to improve system stability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description --- Build minotari_node with metrics feature enabled; Remove unused feature flags; Motivation and Context --- How Has This Been Tested? --- Tested on a seed node. What process can a PR reviewer use to test or verify this change? --- <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Updated the default container configuration to include an expanded set of capabilities for enhanced performance and monitoring. - Improved container startup reliability with a new process management component that ensures smoother signal handling and process reaping. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…6921) Description --- Some times disconnecting a peer can go stale and cause undue lock-ups for the calling thread. With `comms\core\src\connectivity\manager.rs`: - Mitigated the outbound pipeline lockup that can occur when peers are being disconnected. The clean-up loop runs regularly with a 1 min default interval. - Ensured all disconnecting tasks are wrapped in a `tokio::time::timeout(` future. **Note:** Other unwanted lock-up/interlock behaviour may still be related to the outbound pipeline. Motivation and Context --- In a recent system-level test the cleanup performed in `async fn refresh_connection_pool(&mut self, ticker_id: u64)` took 18 min to return, which held up the tokio select loop, with the further knock-on effect to block all `ConnectivityRequest` sent via the outbound pipeline. How Has This Been Tested? --- Performed system-level testing. (_Supportive evidence has been found in the log files for a correlation between the console message `Watched command status failed: deadline has elapsed` and the peer disconnect timeouts._) What process can a PR reviewer use to test or verify this change? --- - Code review - System-level testing <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced connection management with improved logging and error handling for better traceability. - Introduced a timeout mechanism for refreshing connections to mitigate delays. - Added safe disconnection procedures to prevent operations from hanging. - Improved peer selection logging to provide clearer insights into broadcast strategies. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description --- - simplify DNS txt lookup code by using hickory resolver - upgrade hickory to `0.25.0-alpha.4` (from alpha.2) - update tari pulse implementation Motivation and Context --- Hickory-client includes many breaking changes with practically every update (`0.25.0-alpha.2 -> 4` is no exception), and this is a burden to maintain. The `hickory-resolver` is a higher-level crate that abstracts away (hopefully most) breaking changes. The main reason for this PR is that I am updating the feature-dan2 branch to latest development, this led to the need to update our libp2p fork both to update tari-crypto and because libp2p also uses hickory and their version conflicts with the base layer version `0.25.0-alpha.2 `. I have updated to `0.25.0-alpha.4` (what libp2p currently uses) instead of `0.25.1` for this reason. Future hickory upgrades should be simple to implement. How Has This Been Tested? --- Peer seed unit test that queries real DNS What process can a PR reviewer use to test or verify this change? --- Autoupdate, peer seeds and tari pulse should work as before <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **Chores** - Removed deprecated dependencies and updated versions of key components to improve system stability. - **Refactor** - Simplified DNS connectivity and resolution processes for a more efficient networking experience. - Enhanced clarity and maintainability of the DNS client code by transitioning to a struct-based design. - **Tests** - Consolidated testing efforts by removing outdated test code, focusing verification on essential functionality, resulting in reduced test coverage for certain features. Overall, these improvements enhance performance and reliability while reducing complexity. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description --- Delete all stale peers from the peer database: - Stale Nodes: - A node is considered stale if all its addresses have failed or not been seen for more than 5 days. - The node must not be a seed node and be identified as a node (not a client). - Stale Wallets: - A wallet is considered stale if it has never been seen, all its addresses have failed, or it has not been seen for more than 5 days. - The wallet must be identified as a client (not a node). Motivation and Context --- The peer database is growing unwieldy with peer identities that can be created for free and it gets filled up with stale data; this impacts performance. How Has This Been Tested? --- Performed system-level testing. These peers are in the process of being filtered and removed for a nextnet seed node: [list_peers_base_node.log](https://github.com/user-attachments/files/19634367/list_peers_base_node.log) [list_peers_wallet.log](https://github.com/user-attachments/files/19634368/list_peers_wallet.log) What process can a PR reviewer use to test or verify this change? --- Code review System-level testing. <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced an automatic cleanup mechanism for outdated network peers, helping maintain a more stable and reliable connection environment. - Added a timeout mechanism for deleting stale peers from the database. - Enhanced logging in connection maintenance now provides better visibility into connection performance, contributing to improved network responsiveness. - Implemented a method to identify and remove stale wallets from the database, further improving peer management. - Updated criteria for determining stale peers to enhance accuracy in peer management. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Description --- Reduce metrics cardinality - peer id is included as label which creates excessive amount of metrics as we grow the peer list. Motivation and Context --- How Has This Been Tested? --- What process can a PR reviewer use to test or verify this change? --- <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Streamlined internal metrics collection across connection and messaging components. - Metrics now aggregate by connection direction and protocol, rather than tracking individual identifiers. - The improved, simplified reporting enhances overall observability without altering user-facing functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
upgrade openssl and tokio <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Upgraded the asynchronous runtime library across multiple components to version 1.42 for improved performance and stability. - Updated cryptographic libraries to enhance security and reliability, including updates to OpenSSL. - Refined configuration settings to ensure consistency with these dependency enhancements. - Introduced new versions for `tokio` and `openssl` dependencies in the configuration file. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
[//]: # (dependabot-start)⚠️ **Dependabot is rebasing this PR**⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [crossbeam-channel](https://github.com/crossbeam-rs/crossbeam) from 0.5.13 to 0.5.15. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/crossbeam-rs/crossbeam/releases">crossbeam-channel's releases</a>.</em></p> <blockquote> <h2>crossbeam-channel 0.5.15</h2> <ul> <li>Fix regression introduced in 0.5.12 that can lead to a double free when dropping unbounded channel. (<a href="https://redirect.github.com/crossbeam-rs/crossbeam/issues/1187">#1187</a>)</li> </ul> <h2>crossbeam-channel 0.5.14</h2> <ul> <li>Fix stack overflow when sending large value to unbounded channel. (<a href="https://redirect.github.com/crossbeam-rs/crossbeam/issues/1146">#1146</a>, <a href="https://redirect.github.com/crossbeam-rs/crossbeam/issues/1147">#1147</a>)</li> <li>Add <code>Select::new_biased</code> function. (<a href="https://redirect.github.com/crossbeam-rs/crossbeam/issues/1150">#1150</a>)</li> <li>Remove inefficient spinning. (<a href="https://redirect.github.com/crossbeam-rs/crossbeam/issues/1154">#1154</a>)</li> <li>Suppress buggy <code>clippy::zero_repeat_side_effects</code> lint in macro generated code. (<a href="https://redirect.github.com/crossbeam-rs/crossbeam/issues/1123">#1123</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/crossbeam-rs/crossbeam/commit/d35ffde18a76ae9667f602d8c0127ff89ac2e4d4"><code>d35ffde</code></a> Prepare for the next release</li> <li><a href="https://github.com/crossbeam-rs/crossbeam/commit/6ec74ecae896df5fc239518b45a1bfd258c9db68"><code>6ec74ec</code></a> crossbeam-channel: prevent double free on Drop (<a href="https://redirect.github.com/crossbeam-rs/crossbeam/issues/1187">#1187</a>)</li> <li><a href="https://github.com/crossbeam-rs/crossbeam/commit/ccd83ac4108a2a1b41e9c6e79c87267167d18dfa"><code>ccd83ac</code></a> Prepare for the next release</li> <li><a href="https://github.com/crossbeam-rs/crossbeam/commit/54988eb2399c889fb82926c1508bb0ec31bedba2"><code>54988eb</code></a> Calculate layout in const context</li> <li><a href="https://github.com/crossbeam-rs/crossbeam/commit/761d0b67e2849479f7b376b4c02a191f6ed796aa"><code>761d0b6</code></a> Port <a href="https://redirect.github.com/crossbeam-rs/crossbeam/issues/1146">#1146</a> & <a href="https://redirect.github.com/crossbeam-rs/crossbeam/issues/1147">#1147</a> to deque::Injector and queue::SegQueue</li> <li><a href="https://github.com/crossbeam-rs/crossbeam/commit/8144fbb41e67046d341034843887b0dd5963cddb"><code>8144fbb</code></a> Remove optimistic spinning from Context::wait_until</li> <li><a href="https://github.com/crossbeam-rs/crossbeam/commit/a92f6c4fbb5527ef4f86239fd18df426b4e1d84f"><code>a92f6c4</code></a> Bump peter-evans/create-pull-request from 5 to 7 (<a href="https://redirect.github.com/crossbeam-rs/crossbeam/issues/1153">#1153</a>)</li> <li><a href="https://github.com/crossbeam-rs/crossbeam/commit/66d41a904f8f51d82d806b86856d72290202d491"><code>66d41a9</code></a> channel: Add new_biased constructor for biased channel selection (<a href="https://redirect.github.com/crossbeam-rs/crossbeam/issues/1150">#1150</a>)</li> <li><a href="https://github.com/crossbeam-rs/crossbeam/commit/d0d0a80be89a976a66292ed7d3fb562f9d3d590b"><code>d0d0a80</code></a> CachePadded: Use 128-byte alignment on arm64ec</li> <li><a href="https://github.com/crossbeam-rs/crossbeam/commit/f757eefca227f67cb9dc8b90c07500728151f501"><code>f757eef</code></a> Add comment about fixed rustc bug</li> <li>Additional commits viewable in <a href="https://github.com/crossbeam-rs/crossbeam/compare/crossbeam-channel-0.5.13...crossbeam-channel-0.5.15">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/tari-project/tari/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )