Adding fit function implementation #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contained all the fitting function implementations that I completed during the past semester, all of which I presented in the all-hands meetings.
On top of that, I noticed that, at least for mac users, R studio has trouble installing earlier versions of a package due to lack of precompiled libraries in those versions. For example, if you run renv::restore(), hoping that it will automatically install all the required packages for this probability distribution calculator, unfortunately for the package 'Matrix', it will fail to install version "1.6-0", as specified in the previous lock file. In fact, one will only be able to install newer versions, for example [1.7-2], released by R community.
My solution previously was to manually update the version number in the lock file, which is very tedious and repetitively and I took a long time to figure out. Even though specifying versions in a lock file enhances reproducibility, it causes installation errors for certain users.
Given that, I experimented with getting rid of all the "Version:" fields in each package, allowing it to automatically install the latest version, turns out that compilation was perfectly fine with the newest versions, and I was able to run renv::restore() smoothly, and run the app in the same way I used to do.