[feat] 선물 토너먼트 리스트 API 구현 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziiyouth
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Transactional 리드온리두 잘 붙였고 코드 깔끔하네요!!! 굿굿
ziiyouth
requested changes
Jan 12, 2024
There was a problem hiding this comment.
앗 근데 이거 반환해줄 때 상품 url 자체도 같이 주어야 할 거 같아요 !!! 토너먼트 할 때 url 있는 친구들은 클릭해서 열어볼 수 있게 하니까용~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 🍫
Summary 🍪
Before i request PR review 🍰