Refactor/issue 464 sepreate env files by profile #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heesung6701
reviewed
Jan 17, 2023
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 #v.3.5.1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: cp ~/config-injection/ecosystem-${{ env.NODE_ENV }}.json ${{ env.PROJECT_PATH }}/ecosystem.json | ||
| - run: cp ~/config-injection/.env ${{ env.PROJECT_PATH }}/.env | ||
| - run: cp ~/config-injection/ecosystem-${{ env.SERVER_NAME }}.json ${{ env.PROJECT_PATH }}/ecosystem.json |
There was a problem hiding this comment.
NODE_ENV가 아닌 NODE_SERVER를 기준으로 사용한 이유가 있나요? Production과 production1,2는 같은 env를 공유하고있는데 현 방식이 되면 서버 종류만큼 env가 필요하게됩니다!
There was a problem hiding this comment.
NODE_SERVER라는게 SERVER_NAME을 말씀하신거겠죠? 저희가 ecosystem은 서버 종류만큼 가지고 있어서 SERVER_NAME 적용한거고, .env는 NODE_ENV를 기준으로 가져오고 있습니다.
There was a problem hiding this comment.
아 ecosystem이었군요! 제가 env로 잘못봤습니다!
NAME은 식별자보다 보여지는 이름에 더 가까운거 같아서 향후에 NAME대신 ID 혹은 PROFILE로 수정해도 좋을 거 같습니다!
|
@heesung6701 피드백 주신 부분 반영했습니다 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Closes #464
What's being changed:
SERVER_NAMEto matchNODE_ENVhere withNODE_ENVinjected by the ecosystem.12to16. (It was already applied in deploy-development.yml and deploy-test.yml)