Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/issue 464 sepreate env files by profile #465

Merged
merged 3 commits into from
Jan 19, 2023
Merged

Refactor/issue 464 sepreate env files by profile #465

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fce93d1
[Refact] Copy different environment files according to NODE_ENV
ChoHadam Jan 17, 2023
39b5333
[Fix] Upgrade node version
ChoHadam Jan 17, 2023
441b1f9
[Fix] Use SERVER_PROFILE instead of SERVER_NAME
ChoHadam Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/deploy-development.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,20 @@ jobs:
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
defaults:
run:
working-directory: ${{ env.NODE_ENV }}
working-directory: ${{ env.SERVER_NAME }}
steps:
- uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 #v3.1.0
with:
path: ${{ env.NODE_ENV }}
path: ${{ env.SERVER_NAME }}
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 #v.3.5.1
with:
node-version: ${{ matrix.node-version }}
- run: cp ~/config-injection/ecosystem-${{ env.NODE_ENV }}.json ${{ env.PROJECT_PATH }}/ecosystem.json
- run: cp ~/config-injection/.env ${{ env.PROJECT_PATH }}/.env
- run: cp ~/config-injection/ecosystem-${{ env.SERVER_NAME }}.json ${{ env.PROJECT_PATH }}/ecosystem.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NODE_ENV가 아닌 NODE_SERVER를 기준으로 사용한 이유가 있나요? Production과 production1,2는 같은 env를 공유하고있는데 현 방식이 되면 서버 종류만큼 env가 필요하게됩니다!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NODE_SERVER라는게 SERVER_NAME을 말씀하신거겠죠? 저희가 ecosystem은 서버 종류만큼 가지고 있어서 SERVER_NAME 적용한거고, .env는 NODE_ENV를 기준으로 가져오고 있습니다.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 ecosystem이었군요! 제가 env로 잘못봤습니다!
NAME은 식별자보다 보여지는 이름에 더 가까운거 같아서 향후에 NAME대신 ID 혹은 PROFILE로 수정해도 좋을 거 같습니다!

- run: cp ~/config-injection/envs/.env.${{ env.NODE_ENV }} ${{ env.PROJECT_PATH }}/.env
- run: sh ${{ env.PROJECT_PATH }}/script/prebuild.sh
- run: sh ${{ env.PROJECT_PATH }}/script/reload.sh
env:
NODE_ENV: development
SERVER_NAME: development
PROJECT_PATH: ~/actions-runner/_work/A.fume.Server/A.fume.Server/development
11 changes: 6 additions & 5 deletions .github/workflows/deploy-production-1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,20 @@ jobs:
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
defaults:
run:
working-directory: ${{ env.NODE_ENV }}
working-directory: ${{ env.SERVER_NAME }}
steps:
- uses: actions/checkout@v2
with:
path: ${{ env.NODE_ENV }}
path: ${{ env.SERVER_NAME }}
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}
- run: cp ~/config-injection/ecosystem-${{ env.NODE_ENV }}.json ${{ env.PROJECT_PATH }}/ecosystem.json
- run: cp ~/config-injection/.env ${{ env.PROJECT_PATH }}/.env
- run: cp ~/config-injection/ecosystem-${{ env.SERVER_NAME }}.json ${{ env.PROJECT_PATH }}/ecosystem.json
- run: cp ~/config-injection/envs/.env.${{ env.NODE_ENV }} ${{ env.PROJECT_PATH }}/.env
- run: sh ${{ env.PROJECT_PATH }}/script/prebuild.sh
- run: sh ${{ env.PROJECT_PATH }}/script/reload.sh
env:
NODE_ENV: production-1
NODE_ENV: production
SERVER_NAME: production-1
PROJECT_PATH: ~/actions-runner/_work/A.fume.Server/A.fume.Server/production-1
11 changes: 6 additions & 5 deletions .github/workflows/deploy-production-2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,20 @@ jobs:
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
defaults:
run:
working-directory: ${{ env.NODE_ENV }}
working-directory: ${{ env.SERVER_NAME }}
steps:
- uses: actions/checkout@v2
with:
path: ${{ env.NODE_ENV }}
path: ${{ env.SERVER_NAME }}
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}
- run: cp ~/config-injection/ecosystem-${{ env.NODE_ENV }}.json ${{ env.PROJECT_PATH }}/ecosystem.json
- run: cp ~/config-injection/.env ${{ env.PROJECT_PATH }}/.env
- run: cp ~/config-injection/ecosystem-${{ env.SERVER_NAME }}.json ${{ env.PROJECT_PATH }}/ecosystem.json
- run: cp ~/config-injection/envs/.env.${{ env.NODE_ENV }} ${{ env.PROJECT_PATH }}/.env
- run: sh ${{ env.PROJECT_PATH }}/script/prebuild.sh
- run: sh ${{ env.PROJECT_PATH }}/script/reload.sh
env:
NODE_ENV: production-2
NODE_ENV: production
SERVER_NAME: production-2
PROJECT_PATH: ~/actions-runner/_work/A.fume.Server/A.fume.Server/production-2
9 changes: 5 additions & 4 deletions .github/workflows/deploy-production.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,20 @@ jobs:
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
defaults:
run:
working-directory: ${{ env.NODE_ENV }}
working-directory: ${{ env.SERVER_NAME }}
steps:
- uses: actions/checkout@v2
with:
path: ${{ env.NODE_ENV }}
path: ${{ env.SERVER_NAME }}
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}
- run: cp ~/config-injection/ecosystem-${{ env.NODE_ENV }}.json ${{ env.PROJECT_PATH }}/ecosystem.json
- run: cp ~/config-injection/.env ${{ env.PROJECT_PATH }}/.env
- run: cp ~/config-injection/ecosystem-${{ env.SERVER_NAME }}.json ${{ env.PROJECT_PATH }}/ecosystem.json
- run: cp ~/config-injection/envs/.env.${{ env.NODE_ENV }} ${{ env.PROJECT_PATH }}/.env
- run: sh ${{ env.PROJECT_PATH }}/script/prebuild.sh
- run: sh ${{ env.PROJECT_PATH }}/script/reload.sh
env:
NODE_ENV: production
SERVER_NAME: production
PROJECT_PATH: ~/actions-runner/_work/A.fume.Server/A.fume.Server/production
2 changes: 1 addition & 1 deletion .github/workflows/deploy-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- run: cp ~/config-injection/ecosystem-${{ env.NODE_ENV }}.json ${{ env.PROJECT_PATH }}/ecosystem.json
- run: cp ~/config-injection/.env ${{ env.PROJECT_PATH }}/.env
- run: cp ~/config-injection/envs/.env.${{ env.NODE_ENV }} ${{ env.PROJECT_PATH }}/.env
# - run: sudo ${{ env.PROJECT_PATH }}/script/prebuild.sh
- run: ${{ env.PROJECT_PATH }}/script/reload.sh
env:
Expand Down