Feature: Create FeaturedTopic and FeaturedTopicsRow Components #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es of hitting 3 with descriptions
akiva10b
reviewed
Jan 16, 2025
static/css/s2.css
Outdated
| margin-inline-start: 30px; | ||
| margin-top: 19px; | ||
| width: 207.593px; | ||
| /*height: 140.617px;*/ |
There was a problem hiding this comment.
remove if we dont need it
| margin-inline-end: 30px; | ||
| margin-inline-start: 30px; | ||
| margin-top: 19px; | ||
| width: 207.593px; |
| .topic-card-with-description .cardDescription{ | ||
| margin-inline-end: 30px; | ||
| margin-inline-start: 30px; | ||
| margin-top: 19px; |
There was a problem hiding this comment.
these numbers for width and height seem pretty random, also on top seems like there are very specific numbers. ideally the cards wont have a strict width and height but rather a min-width min-height. Sefaria in general tries to stick to multiples of 5 for margins and width/height
static/css/s2.css
Outdated
| } | ||
| .topic-card-with-description .card{ | ||
| flex: 1; | ||
| border-top: 4px solid var(--Sefaria-Blue, #18345D); |
There was a problem hiding this comment.
why are we adding the color as a default, I believe --Sefaria-Blue should always be defined
|
|
||
| const fetchRandomTopicDeck = async () => { | ||
| const poolName = Sefaria.getLangSpecificTopicPoolName('general'); | ||
| const topics = await Sefaria.getTopicsByPool(poolName, Math.pow(numTopics, 3)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New Component:
RandomTopicCardWithDescriptionRowFetches a set of random topics with descriptions.
Displays topics in a responsive card row format, including links to learn more.
Code Changes
The following changes were made to the files below
Notes
Any additional notes go here